rootslab/brando

Similar blocks of code found in 2 locations. Consider refactoring.
Open

var log = console.log
    , floor = Math.floor
    , random = Math.random
    , PartPerm = require( '../lib/filters/emitters/partperm' )
    , test = function ( mbytes, items, range ) {

Found in bench/parse-pp-emt-simple-bench.js and 1 other location - About 2 days to fix

Read up
Read up

bench/parse-sq-emt-simple-bench.js on lines 1..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 379.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Similar blocks of code found in 2 locations. Consider refactoring.
Open

var log = console.log
    , floor = Math.floor
    , random = Math.random
    , Sequence = require( '../lib/filters/emitters/sequence' )
    , test = function ( mbytes, items, range ) {

Found in bench/parse-sq-emt-simple-bench.js and 1 other location - About 2 days to fix

Read up
Read up

bench/parse-pp-emt-simple-bench.js on lines 1..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 379.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Don't Repeat Yourself on the C2 Wiki
Duplicated Code on SourceMaking
Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76

Function `exports` has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = ( function () {

    if ( ! Buffer.readUInt24LE ) require( '../utils/buffer' );

    var abs = Math.abs

Found in lib/filters/emitters/sequence.js - About 7 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `Brando` has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

exports.Brando = ( function () {
    var log = console.log
        , abs = Math.abs
        , max = Math.max
        , ceil = Math.ceil

Found in lib/brando.js - About 6 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `exports` has 122 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = ( function () {

    if ( ! Buffer.readUInt24LE ) require( '../utils/buffer' );

    var abs = Math.abs

Found in lib/filters/emitters/sequence.js - About 4 hrs to fix

Function `exports` has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = ( function () {

    var abs = Math.abs
        , ceil = Math.ceil
        , dlog = Math.log

Found in lib/filters/streams/sequence-transform.js - About 4 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `exports` has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = ( function () {

    if ( ! Buffer.readUInt24LE ) require( '../utils/buffer' );

    var floor = Math.floor

Found in lib/filters/emitters/partperm.js - About 3 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `Brando` has 87 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.Brando = ( function () {
    var log = console.log
        , abs = Math.abs
        , max = Math.max
        , ceil = Math.ceil

Found in lib/brando.js - About 3 hrs to fix

Function `exports` has 87 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = ( function () {

    if ( ! Buffer.readUInt24LE ) require( '../utils/buffer' );

    var floor = Math.floor

Found in lib/filters/emitters/partperm.js - About 3 hrs to fix

Function `exports` has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = ( function () {

    var abs = Math.abs
        , ceil = Math.ceil
        , dlog = Math.log

Found in lib/filters/streams/sequence-transform.js - About 3 hrs to fix

Function `exports` has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = ( function () {

    if ( ! Buffer.readUInt24LE ) require( '../utils/buffer' );

    var abs = Math.abs

Found in lib/filters/emitters/fullperm.js - About 3 hrs to fix

Function `exports` has 76 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = ( function () {

    var min = Math.min
        , max = Math.max
        , ceil = Math.ceil

Found in lib/filters/streams/fullperm-transform.js - About 3 hrs to fix

Function `exports` has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = ( function () {

    if ( ! Buffer.readUInt24LE ) require( '../utils/buffer' );

    var abs = Math.abs

Found in lib/filters/emitters/fullperm.js - About 2 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `exports` has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = ( function () {

    if ( Buffer.prototype.readUInt24LE ) return;

    // See also my PR#169 https://github.com/iojs/io.js/pull/169

Found in lib/filters/utils/buffer.js - About 2 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `exports` has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = ( function () {

    var min = Math.min
        , max = Math.max
        , ceil = Math.ceil

Found in lib/filters/streams/fullperm-transform.js - About 2 hrs to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading

Function `sham` has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        , sham : function ( items, range, repeat ) {
            var i = ( abs( + items ) >>> 0 ) || 1
                , r = ( abs( + range ) >>> 0 ) || 1
                , seq = repeat !== 1
                , ibits = max( ceil( dlog( r ) / log2 ), 1 )

Found in lib/brando.js - About 2 hrs to fix

Function `exports` has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = ( function () {

    var min = Math.min
        , util = require( 'util' )
        , Toni = require( 'toni' )

Found in lib/filters/streams/partperm-transform.js - About 2 hrs to fix

Function `exports` has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = ( function () {

    if ( Buffer.prototype.readUInt24LE ) return;

    // See also my PR#169 https://github.com/iojs/io.js/pull/169

Found in lib/filters/utils/buffer.js - About 1 hr to fix

Function `parse` has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    sproto.parse = function ( data ) {
        var me = this
            , bcomp = me.bcompare
            , result = me.result
            , tbytes = me.tbytes

Found in lib/filters/emitters/sequence.js - About 1 hr to fix

Function `exports` has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = ( function () {

    var min = Math.min
        , util = require( 'util' )
        , Toni = require( 'toni' )

Found in lib/filters/streams/partperm-transform.js - About 1 hr to fix

Read up
Read up

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
Code is considered more complex for each "break in the linear flow of the code"
Code is considered more complex when "flow breaking structures are nested"

Further reading