Sign upLogin

rootslab/spade

View on GitHub
Star

Showing 20 of 20 total issues

Function Spade has a Cognitive Complexity of 127 (exceeds 5 allowed). Consider refactoring.
Open

exports.Spade = ( function () {
    var emitter = require( 'events' ).EventEmitter
        , util = require( 'util' )
        , Bolgia = require( 'bolgia' )
        , Cocker = require( 'cocker' )
Severity: Minor
Found in lib/spade.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Spade has 348 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.Spade = ( function () {
    var emitter = require( 'events' ).EventEmitter
        , util = require( 'util' )
        , Bolgia = require( 'bolgia' )
        , Cocker = require( 'cocker' )
Severity: Major
Found in lib/spade.js - About 1 day to fix

    Function exports has a Cognitive Complexity of 68 (exceeds 5 allowed). Consider refactoring.
    Open

    module.exports = function ( client ) {

    var Bolgia = require( 'bolgia' )
        , clone = Bolgia.clone
        , improve = Bolgia.improve
    Severity: Minor
    Found in lib/iterators/scan.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function Spade has 202 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            , Spade = function ( opt ) {
            var me = this
                , is = me instanceof Spade
                ;
            if ( ! is ) return new Spade( opt );
    Severity: Major
    Found in lib/spade.js - About 1 day to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      client.on( 'ready', function () {
    client.commands.multi( function ( err, data, fn ) {
        log( 'multi:', fn( data )  );
        setTimeout( function () {
            client.commands.ping( function ( err, data, fn ) {
      Severity: Major
      Found in example/transaction-discard-example.js and 1 other location - About 7 hrs to fix
      example/transaction-exec-example.js on lines 19..36

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 183.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      client.on( 'ready', function () {
    client.commands.multi( function ( err, data, fn ) {
        log( 'multi:', fn( data ) );
        setTimeout( function () {
            client.commands.ping( function ( err, data, fn ) {
      Severity: Major
      Found in example/transaction-exec-example.js and 1 other location - About 7 hrs to fix
      example/transaction-discard-example.js on lines 17..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 183.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      File spade.js has 350 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*
 * ♠ Spade, a robust, full-featured, multi-modular Redis client, with offline queue
 * for commands, automatic socket reconnection and command rollback mechanism
 * for subscriptions, moreover, it supports caching for LUA scripts.
 *
      Severity: Minor
      Found in lib/spade.js - About 4 hrs to fix

        Function exports has 91 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        module.exports = function ( client ) {

    var Bolgia = require( 'bolgia' )
        , clone = Bolgia.clone
        , improve = Bolgia.improve
        Severity: Major
        Found in lib/iterators/scan.js - About 3 hrs to fix

          Function exports has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
          Open

          module.exports = function ( client ) {

    var abs = Math.abs
        , emptyFn = function () {}
        , qq = client.qq
          Severity: Minor
          Found in lib/tasks/connection.js - About 3 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function scankeys has 73 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  , scankeys = function ( cname ) {
            var sscanFn = function ( key, cursor, opt, cback ) {
                    var options = improve( clone( opt ), scan_opt )
                        , ckeys = null
                        , ccur = -1
          Severity: Major
          Found in lib/iterators/scan.js - About 2 hrs to fix

            Function exports has 56 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            module.exports = function ( client ) {

    var abs = Math.abs
        , emptyFn = function () {}
        , qq = client.qq
            Severity: Major
            Found in lib/tasks/connection.js - About 2 hrs to fix

              Function pollingFn has 47 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      , pollingFn = function ( done, msg, timeout, reconnect ) {
            var me = this
                , socket = me.socket
                , queue = me.queue
                , qstatus = queue.status
              Severity: Minor
              Found in lib/tasks/connection.js - About 1 hr to fix

                Function onParserMatch has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                                , onParserMatch = function ( err_reply, data, fn ) {
                    // get queue head
                    var cmd = null
                        , message = null
                        , mtype = null
                Severity: Minor
                Found in lib/spade.js - About 1 hr to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      var isArray = Array.isArray
        , files = [
            'connection'
        ]
        , flist = isArray( file_list ) && file_list.length ? file_list : files.concat()
                  Severity: Major
                  Found in lib/tasks/index.js and 1 other location - About 1 hr to fix
                  lib/iterators/index.js on lines 6..14

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 70.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      var isArray = Array.isArray
        , files = [
            'scan'
        ]
        , flist = isArray( file_list ) && file_list.length ? file_list : files.concat()
                  Severity: Major
                  Found in lib/iterators/index.js and 1 other location - About 1 hr to fix
                  lib/tasks/index.js on lines 6..14

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 70.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                  var log = console.log
    , util = require( 'util' )
    , Spade = require( '../' )
    , client = Spade()
    , cback = function ( err, data, fn ) {
                  Severity: Major
                  Found in example/transaction-exec-example.js and 4 other locations - About 1 hr to fix
                  example/monitor-example.js on lines 5..13
                  example/offline-queue.js on lines 5..13
                  example/subscribe-example.js on lines 5..13
                  example/transaction-nested-multi-example.js on lines 5..13

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 56.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                  var log = console.log
    , util = require( 'util' )
    , Spade = require( '../' )
    , client = Spade()
    , cback = function ( err, data, fn ) {
                  Severity: Major
                  Found in example/offline-queue.js and 4 other locations - About 1 hr to fix
                  example/monitor-example.js on lines 5..13
                  example/subscribe-example.js on lines 5..13
                  example/transaction-exec-example.js on lines 5..13
                  example/transaction-nested-multi-example.js on lines 5..13

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 56.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                  var log = console.log
    , util = require( 'util' )
    , Spade = require( '../' )
    , client = Spade()
    , cback = function ( err, data, fn ) {
                  Severity: Major
                  Found in example/subscribe-example.js and 4 other locations - About 1 hr to fix
                  example/monitor-example.js on lines 5..13
                  example/offline-queue.js on lines 5..13
                  example/transaction-exec-example.js on lines 5..13
                  example/transaction-nested-multi-example.js on lines 5..13

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 56.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                  var log = console.log
    , util = require( 'util' )
    , Spade = require( '../' )
    , client = Spade()
    , cback = function ( err, data, fn ) {
                  Severity: Major
                  Found in example/transaction-nested-multi-example.js and 4 other locations - About 1 hr to fix
                  example/monitor-example.js on lines 5..13
                  example/offline-queue.js on lines 5..13
                  example/subscribe-example.js on lines 5..13
                  example/transaction-exec-example.js on lines 5..13

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 56.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 5 locations. Consider refactoring.
                  Open

                  var log = console.log
    , util = require( 'util' )
    , Spade = require( '../' )
    , client = Spade()
    , cback = function ( err, data, fn ) {
                  Severity: Major
                  Found in example/monitor-example.js and 4 other locations - About 1 hr to fix
                  example/offline-queue.js on lines 5..13
                  example/subscribe-example.js on lines 5..13
                  example/transaction-exec-example.js on lines 5..13
                  example/transaction-nested-multi-example.js on lines 5..13

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 56.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language