rootslab/vapid

View on GitHub

Showing 66 of 66 total issues

File pubsub.js has 345 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * PUBSUB mix-ins.
 */

exports.commands = function () {
Severity: Minor
Found in lib/commands/pubsub.js - About 4 hrs to fix

    Function Vapid has 99 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            , Vapid = function ( opt ) {
                var me = this
                    , is = me instanceof Vapid
                    ;
                if ( ! is ) return new Vapid( opt );
    Severity: Major
    Found in lib/vapid.js - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  for ( s = 0; s < splen; ++s ) {
                      pname = spatterns[ s ];
                      pattern = ppatterns[ pname ];
                      // check if pattern exists
                      if ( ! pattern ) continue;
      Severity: Major
      Found in lib/vapid.js and 1 other location - About 3 hrs to fix
      lib/vapid.js on lines 85..98

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 109.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  for ( ; s < sclen; ++s ) {
                      cname = schannels[ s ];
                      channel = pchannels[ cname ];
                      // check if channel exists
                      if ( ! channel ) continue;
      Severity: Major
      Found in lib/vapid.js and 1 other location - About 3 hrs to fix
      lib/vapid.js on lines 99..112

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 109.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  var me = this
                      , patterns = me.pubsub.patterns
                      , spatterns = null
                      , alen = args.length
                      , a = 0
      Severity: Major
      Found in lib/commands/pubsub.js and 1 other location - About 3 hrs to fix
      lib/commands/pubsub.js on lines 152..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 104.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  var me = this
                      , channels = me.pubsub.channels
                      , schannels = null
                      , alen = args.length
                      , a = 0
      Severity: Major
      Found in lib/commands/pubsub.js and 1 other location - About 3 hrs to fix
      lib/commands/pubsub.js on lines 198..210

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 104.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      File vapid.js has 303 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*
       * Vapid, a vacuous Redis implementation for connection tests,
       * with a fully functional PubSub system for multiple clients.
       *
       * Copyright(c) 2014 Guglielmo Ferri <44gatti@gmail.com>
      Severity: Minor
      Found in lib/vapid.js - About 3 hrs to fix

        Function BulkRule has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.BulkRule = ( function () {
            var Rule = require('./rule').Rule
                , util = require( 'util' )
                , BulkRule = function ( char ) {
                    var me = this
        Severity: Minor
        Found in lib/parser/rules/bulk.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function onConnection has 77 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                        , onConnection = function ( sock ) {
                            var me = this
                                , clients = me.clients
                                , cqueues = me.cqueues
                                , parsers = me.parsers
        Severity: Major
        Found in lib/vapid.js - About 3 hrs to fix

          Function commands has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.commands = function () {
          
              var wmsg = function ( cmd ) {
                      return '-ERR wrong number of arguments for \'' + cmd + '\' command\r\n';
                  }
          Severity: Minor
          Found in lib/commands/connection.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function unsubscribe has 65 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  , unsubscribe : function ( command, args, sock ) {
                      var me = this
                          , channels = me.pubsub.channels
                          , alen = args.length
                          , a = 0
          Severity: Major
          Found in lib/commands/pubsub.js - About 2 hrs to fix

            Function punsubscribe has 65 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    , punsubscribe : function ( command, args, sock ) {
                       var me = this
                            , patterns = me.pubsub.patterns
                            , alen = args.length
                            , a = 0
            Severity: Major
            Found in lib/commands/pubsub.js - About 2 hrs to fix

              Function BulkRule has 59 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              exports.BulkRule = ( function () {
                  var Rule = require('./rule').Rule
                      , util = require( 'util' )
                      , BulkRule = function ( char ) {
                          var me = this
              Severity: Major
              Found in lib/parser/rules/bulk.js - About 2 hrs to fix

                Function commands has 54 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                exports.commands = function () {
                
                    var wmsg = function ( cmd ) {
                            return '-ERR wrong number of arguments for \'' + cmd + '\' command\r\n';
                        }
                Severity: Major
                Found in lib/commands/connection.js - About 2 hrs to fix

                  Identical blocks of code found in 4 locations. Consider refactoring.
                  Open

                  var add = function () {
                      var s = Spade( spade_opt )
                          , commands = s.commands
                          ;
                      publisher = s;
                  Severity: Major
                  Found in bench/spade-vapid-short-message-bench.js and 3 other locations - About 1 hr to fix
                  bench/spade-redis-long-message-bench.js on lines 90..99
                  bench/spade-redis-pubsub-short-message-bench.js on lines 80..89
                  bench/spade-vapid-pubsub-long-message-bench.js on lines 86..95

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 72.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 4 locations. Consider refactoring.
                  Open

                  var add = function () {
                      var s = Spade( spade_opt )
                          , commands = s.commands
                          ;
                      publisher = s;
                  Severity: Major
                  Found in bench/spade-vapid-pubsub-long-message-bench.js and 3 other locations - About 1 hr to fix
                  bench/spade-redis-long-message-bench.js on lines 90..99
                  bench/spade-redis-pubsub-short-message-bench.js on lines 80..89
                  bench/spade-vapid-short-message-bench.js on lines 82..91

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 72.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 4 locations. Consider refactoring.
                  Open

                  var add = function () {
                      var s = Spade( spade_opt )
                          , commands = s.commands
                          ;
                      publisher = s;
                  Severity: Major
                  Found in bench/spade-redis-pubsub-short-message-bench.js and 3 other locations - About 1 hr to fix
                  bench/spade-redis-long-message-bench.js on lines 90..99
                  bench/spade-vapid-pubsub-long-message-bench.js on lines 86..95
                  bench/spade-vapid-short-message-bench.js on lines 82..91

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 72.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 4 locations. Consider refactoring.
                  Open

                  var add = function () {
                      var s = Spade( spade_opt )
                          , commands = s.commands
                          ;
                      publisher = s;
                  Severity: Major
                  Found in bench/spade-redis-long-message-bench.js and 3 other locations - About 1 hr to fix
                  bench/spade-redis-pubsub-short-message-bench.js on lines 80..89
                  bench/spade-vapid-pubsub-long-message-bench.js on lines 86..95
                  bench/spade-vapid-short-message-bench.js on lines 82..91

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 72.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                  var sendCommands = function () {
                      var i = 0
                          , client = null
                          , pcmd = publisher.commands.publish
                          ;
                  Severity: Major
                  Found in bench/spade-redis-long-message-bench.js and 3 other locations - About 1 hr to fix
                  bench/spade-redis-pubsub-short-message-bench.js on lines 43..50
                  bench/spade-vapid-pubsub-long-message-bench.js on lines 48..55
                  bench/spade-vapid-short-message-bench.js on lines 45..52

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 71.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                  var sendCommands = function () {
                      var i = 0
                          , client = null
                          , pcmd = publisher.commands.publish
                          ;
                  Severity: Major
                  Found in bench/spade-redis-pubsub-short-message-bench.js and 3 other locations - About 1 hr to fix
                  bench/spade-redis-long-message-bench.js on lines 52..59
                  bench/spade-vapid-pubsub-long-message-bench.js on lines 48..55
                  bench/spade-vapid-short-message-bench.js on lines 45..52

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 71.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language