Sign upLogin

rootstrap/RSFormView

View on GitHub
Star

Showing 12 of 14 total issues

Function testForm has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  func testForm() {
    app.launch()
    let emailTextField = app.textField(with: "EMAIL")
    emailTextField.tap()
    emailTextField.typeText("german.stabile")
Severity: Major
Found in FullFormExample/RSFormViewExampleAppUITests/RSFormViewExampleAppUITests.swift - About 2 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    import UIKit

@UIApplicationMain
class AppDelegate: UIResponder, UIApplicationDelegate {
    Severity: Minor
    Found in FullFormExample/RSFormViewExampleApp/AppDelegate.swift and 1 other location - About 55 mins to fix
    VanillaExample/RSFormViewVanillaExample/AppDelegate.swift on lines 9..20

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 64.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    import UIKit

@UIApplicationMain
class AppDelegate: UIResponder, UIApplicationDelegate {
    Severity: Minor
    Found in VanillaExample/RSFormViewVanillaExample/AppDelegate.swift and 1 other location - About 55 mins to fix
    FullFormExample/RSFormViewExampleApp/AppDelegate.swift on lines 9..22

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 64.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      func zipItem() -> FormItem {
    let zipField = FormField(name: FieldName.zip.rawValue,
                             initialValue: "",
                             placeholder: FieldName.zip.rawValue,
                             fieldType: .fiveDigitZipCode,
    Severity: Major
    Found in FullFormExample/RSFormViewExampleApp/SignupExampleViewModel.swift and 3 other locations - About 45 mins to fix
    FullFormExample/RSFormViewExampleApp/SignupExampleViewModel.swift on lines 79..88
    FullFormExample/RSFormViewExampleApp/SignupExampleViewModel.swift on lines 115..124
    FullFormExample/RSFormViewExampleApp/SignupExampleViewModel.swift on lines 155..164

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      func addressItem() -> FormItem {
    let addressField = FormField(name: FieldName.address.rawValue,
                                 initialValue: "",
                                 placeholder: FieldName.address.rawValue,
                                 fieldType: .regular,
    Severity: Major
    Found in FullFormExample/RSFormViewExampleApp/SignupExampleViewModel.swift and 3 other locations - About 45 mins to fix
    FullFormExample/RSFormViewExampleApp/SignupExampleViewModel.swift on lines 79..88
    FullFormExample/RSFormViewExampleApp/SignupExampleViewModel.swift on lines 144..153
    FullFormExample/RSFormViewExampleApp/SignupExampleViewModel.swift on lines 155..164

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      func birthDateItem() -> FormItem {
    let birthdateField = FormField(name: FieldName.birthdate.rawValue,
                                   initialValue: "",
                                   placeholder: FieldName.birthdate.rawValue,
                                   fieldType: .date,
    Severity: Major
    Found in FullFormExample/RSFormViewExampleApp/SignupExampleViewModel.swift and 3 other locations - About 45 mins to fix
    FullFormExample/RSFormViewExampleApp/SignupExampleViewModel.swift on lines 79..88
    FullFormExample/RSFormViewExampleApp/SignupExampleViewModel.swift on lines 115..124
    FullFormExample/RSFormViewExampleApp/SignupExampleViewModel.swift on lines 144..153

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      func emailItem() -> FormItem {
    let emailField = FormField(name: FieldName.email.rawValue,
                               initialValue: "",
                               placeholder: FieldName.email.rawValue,
                               fieldType: .email,
    Severity: Major
    Found in FullFormExample/RSFormViewExampleApp/SignupExampleViewModel.swift and 3 other locations - About 45 mins to fix
    FullFormExample/RSFormViewExampleApp/SignupExampleViewModel.swift on lines 115..124
    FullFormExample/RSFormViewExampleApp/SignupExampleViewModel.swift on lines 144..153
    FullFormExample/RSFormViewExampleApp/SignupExampleViewModel.swift on lines 155..164

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    extension TextFieldCell: TextFieldDelegate {
  public func didUpdate(textFieldView: TextFieldView, with fieldData: FormField) {
    textFieldView.textField.text = fieldData.value
    delegate?.didUpdate(data: fieldData)
  }
    Severity: Minor
    Found in RSFormView/Classes/Views/Cell/TextFieldCell.swift and 1 other location - About 45 mins to fix
    RSFormView/Classes/Views/Cell/TwoTextFieldsCell.swift on lines 52..57

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    extension TwoTextFieldsCell: TextFieldDelegate {
  public func didUpdate(textFieldView: TextFieldView, with fieldData: FormField) {
    textFieldView.textField.text = fieldData.value
    delegate?.didUpdate(data: fieldData)
  }
    Severity: Minor
    Found in RSFormView/Classes/Views/Cell/TwoTextFieldsCell.swift and 1 other location - About 45 mins to fix
    RSFormView/Classes/Views/Cell/TextFieldCell.swift on lines 54..59

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    import Foundation

/**
 Single field row.
 */
    Severity: Minor
    Found in RSFormView/Classes/Models/TextFieldCellItem.swift and 1 other location - About 35 mins to fix
    FullFormExample/RSFormViewExampleApp/CustomRows/StepperCellItem.swift on lines 9..21

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    import Foundation
import RSFormView

final class StepperCellItem: FormItem {
    Severity: Minor
    Found in FullFormExample/RSFormViewExampleApp/CustomRows/StepperCellItem.swift and 1 other location - About 35 mins to fix
    RSFormView/Classes/Models/TextFieldCellItem.swift on lines 8..25

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this function.
    Open

        return true
    Severity: Major
    Found in RSFormView/Classes/Extensions/StringExtension.swift - About 30 mins to fix
      Severity
      Category
      Status
      Source
      Language