Sign upLogin

roqua/quby_engine

View on GitHub
Star
lib/quby/answers/entities/answer.rb

Summary

Maintainability
D
2 days
Test Coverage

Method value_by_regular_values has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
Open

        def value_by_regular_values
          result = {}
          if value
            result = value.dup
            value.each do |key, answer|
Severity: Minor
Found in lib/quby/answers/entities/answer.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class Answer has 30 methods (exceeds 20 allowed). Consider refactoring.
Open

      class Answer
        extend ActiveModel::Naming
        extend ActiveModel::Translation

        # @return [String]
Severity: Minor
Found in lib/quby/answers/entities/answer.rb - About 3 hrs to fix

    File answer.rb has 273 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'active_model'
require 'quby/answers/entities/outcome'
require 'quby/answers/dsl'

module Quby
    Severity: Minor
    Found in lib/quby/answers/entities/answer.rb - About 2 hrs to fix

      Method value_by_values has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

              def value_by_values
          result = {}
          if value
            result = value.dup
            value.each_key do |key|
      Severity: Minor
      Found in lib/quby/answers/entities/answer.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                      result[key] = answer.to_f if answer
      Severity: Major
      Found in lib/quby/answers/entities/answer.rb - About 45 mins to fix

        Method extra_failed_validations has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

                def extra_failed_validations
          @extra_failed_validations = {}
          questionnaire.questions.each do |q|
            next unless q
            unless q.raw_content.blank?
        Severity: Minor
        Found in lib/quby/answers/entities/answer.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method calc_answered has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

                def calc_answered(qkeys)
          answered = 0
          qkeys.each do |qk|
            ans = send(qk)
            if ans.is_a? Hash # in case of check_box, only count checked check_boxes as answered
        Severity: Minor
        Found in lib/quby/answers/entities/answer.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method extra_question_values has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

                def extra_question_values
          @extra_question_values = {}
          questionnaire.questions.each do |q|
            next unless q
            unless q.raw_content.blank?
        Severity: Minor
        Found in lib/quby/answers/entities/answer.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method mark_completed has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

                def mark_completed(start_time)
          if completed? || @aborted
            self.started_at = start_time if started_at.blank?
            self.completed_at = Time.now if completed_at.blank?
          end
        Severity: Minor
        Found in lib/quby/answers/entities/answer.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                rescue Exception => e
          if defined? Roqua::Support::Errors
            Roqua::Support::Errors.report e, root_path: Rails.root.to_s
          end
          raise e if Rails.env.development? || Rails.env.test?
        Severity: Minor
        Found in lib/quby/answers/entities/answer.rb and 1 other location - About 55 mins to fix
        lib/quby/answers/entities/answer.rb on lines 250..257

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 44.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                rescue Exception => e
          if defined? Roqua::Support::Errors
            Roqua::Support::Errors.report e, root_path: Rails.root.to_s
          end
          raise e if Rails.env.development? || Rails.env.test?
        Severity: Minor
        Found in lib/quby/answers/entities/answer.rb and 1 other location - About 55 mins to fix
        lib/quby/answers/entities/answer.rb on lines 223..230

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 44.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status