Sign upLogin

roqua/quby_engine

View on GitHub
Star
lib/quby/answers/services/answer_validations.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method cleanup_input has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

        def cleanup_input
          questionnaire.questions.each do |question|
            next unless question
            next if question.hidden?
Severity: Minor
Found in lib/quby/answers/services/answer_validations.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method clear? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        def clear?(answer, question)
          # rubocop:disable LineLength
          return true if question.is_a?(Questionnaires::Entities::Questions::SelectQuestion)  && answer == question.extra_data[:placeholder].to_s
          return true if question.is_a?(Questionnaires::Entities::Questions::StringQuestion)  && answer == ""
          return true if question.is_a?(Questionnaires::Entities::Questions::TextQuestion)    && answer == ""
Severity: Minor
Found in lib/quby/answers/services/answer_validations.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

          return true if hidden_questions&.include?(question.key)
Severity: Major
Found in lib/quby/answers/services/answer_validations.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

              return true if question.is_a?(Questionnaires::Entities::Questions::FloatQuestion)   && answer == ""
    Severity: Major
    Found in lib/quby/answers/services/answer_validations.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                return true if parent_option_is_not_selected(question)
      Severity: Major
      Found in lib/quby/answers/services/answer_validations.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status