ros-testing/hypothesis-ros

View on GitHub

Showing 23 of 32 total issues

Similar blocks of code found in 8 locations. Consider refactoring.
Open

@defines_strategy
def uint64(min_value=UINT64_MIN_VALUE, max_value=UINT64_MAX_VALUE):
    """
    Generate value for ROS1 builtin message type "uint64".

Severity: Major
Found in hypothesis_ros/message_fields.py and 7 other locations - About 1 hr to fix
hypothesis_ros/message_fields.py on lines 97..116
hypothesis_ros/message_fields.py on lines 119..138
hypothesis_ros/message_fields.py on lines 141..160
hypothesis_ros/message_fields.py on lines 163..182
hypothesis_ros/message_fields.py on lines 185..204
hypothesis_ros/message_fields.py on lines 207..226
hypothesis_ros/message_fields.py on lines 229..248

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

@defines_strategy
def int16(min_value=INT16_MIN_VALUE, max_value=INT16_MAX_VALUE):
    """
    Generate value for ROS1 builtin message type "int16".

Severity: Major
Found in hypothesis_ros/message_fields.py and 7 other locations - About 1 hr to fix
hypothesis_ros/message_fields.py on lines 97..116
hypothesis_ros/message_fields.py on lines 119..138
hypothesis_ros/message_fields.py on lines 163..182
hypothesis_ros/message_fields.py on lines 185..204
hypothesis_ros/message_fields.py on lines 207..226
hypothesis_ros/message_fields.py on lines 229..248
hypothesis_ros/message_fields.py on lines 251..270

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 8 locations. Consider refactoring.
Open

@defines_strategy
def int32(min_value=INT32_MIN_VALUE, max_value=INT32_MAX_VALUE):
    """
    Generate value for ROS1 builtin message type "int32".

Severity: Major
Found in hypothesis_ros/message_fields.py and 7 other locations - About 1 hr to fix
hypothesis_ros/message_fields.py on lines 97..116
hypothesis_ros/message_fields.py on lines 119..138
hypothesis_ros/message_fields.py on lines 141..160
hypothesis_ros/message_fields.py on lines 163..182
hypothesis_ros/message_fields.py on lines 207..226
hypothesis_ros/message_fields.py on lines 229..248
hypothesis_ros/message_fields.py on lines 251..270

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 44.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language