rosedu/wouso

View on GitHub

Showing 2,707 of 2,707 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def setUp(self):
        self.user = User.objects.create(username='test')
        self.player = self.user.get_profile()
Severity: Minor
Found in wouso/core/magic/tests.py and 1 other location - About 50 mins to fix
wouso/core/god/tests.py on lines 13..15

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

def try_using_cookie_no_recurse(username, first_name, last_name, email, password, cookie):
    username = username+cookie
    return (username, add_user_helper(username, first_name, last_name, email, password))
Severity: Minor
Found in wouso/utils/add_users_force_to_race.py and 1 other location - About 50 mins to fix
wouso/utils/add_users_force.py on lines 37..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    def setUp(self):
        self.user = User.objects.create(username='testgod')
        self.player = self.user.get_profile()
Severity: Minor
Found in wouso/core/god/tests.py and 1 other location - About 50 mins to fix
wouso/core/magic/tests.py on lines 26..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

def try_using_cookie_no_recurse(username, first_name, last_name, email, password, cookie):
    username = username+cookie
    return (username, add_user_helper(username, first_name, last_name, email, password))
Severity: Minor
Found in wouso/utils/add_users_force.py and 1 other location - About 50 mins to fix
wouso/utils/add_users_force_to_race.py on lines 37..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 36.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

                    if ( context.ownerDocument && (elem = context.ownerDocument.getElementById( m )) &&
                        contains( context, elem ) && elem.id === m ) {
                        results.push( elem );
                        return results;
                    }
Severity: Major
Found in wouso/resources/static/js/jquery.js - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                    for (j=0; j < files.length; j++) {
                        a.push({name: n, value: files[j], type: el.type});
                    }
    Severity: Major
    Found in wouso/resources/static/js/jquery.form.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                      if ( ( ofType ? node.nodeName.toLowerCase() === name : node.nodeType === 1 ) && ++diff ) {
                                          // Cache the index of each encountered element
                                          if ( useCache ) {
                                              (node[ expando ] || (node[ expando ] = {}))[ type ] = [ dirruns, diff ];
                                          }
      Severity: Major
      Found in wouso/resources/static/js/jquery.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                while ( j-- ) {
                                    if ( jQuery.nodeName( (tbody = elem.childNodes[j]), "tbody" ) && !tbody.childNodes.length ) {
                                        elem.removeChild( tbody );
                                    }
                                }
        Severity: Major
        Found in wouso/resources/static/js/jquery.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if ( hasScripts ) {
                                      jQuery.merge( scripts, getAll( node, "script" ) );
                                  }
          Severity: Major
          Found in wouso/resources/static/js/jquery.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                if ( elem && elem.parentNode ) {
                                    // Handle the case where IE, Opera, and Webkit return items
                                    // by name instead of ID
                                    if ( elem.id === m ) {
                                        results.push( elem );
            Severity: Major
            Found in wouso/resources/static/js/jquery.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                              if ( !status && options.isLocal && !options.crossDomain ) {
                                                  status = responses.text ? 200 : 404;
                                              // IE - #1450: sometimes returns 1223 when it should be 204
                                              } else if ( status === 1223 ) {
                                                  status = 204;
              Severity: Major
              Found in wouso/resources/static/js/jquery.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if ( matches[ sel ] === undefined ) {
                                            matches[ sel ] = handleObj.needsContext ?
                                                jQuery( sel, this ).index( cur ) >= 0 :
                                                jQuery.find( sel, this, null, [ cur ] ).length;
                                        }
                Severity: Major
                Found in wouso/resources/static/js/jquery.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                              if (elements) 
                                  elements.push(el);
                  Severity: Major
                  Found in wouso/resources/static/js/jquery.form.js - About 45 mins to fix

                    Function init has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        init: function( elem, options, prop, end, easing, unit ) {
                    Severity: Minor
                    Found in wouso/resources/static/js/jquery.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                          if ( Expr.relative[ tokens[j].type ] ) {
                                              break;
                                          }
                      Severity: Major
                      Found in wouso/resources/static/js/jquery.js - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                            if ( name in thisCache ) {
                                                name = [ name ];
                                            } else {
                                                name = name.split(" ");
                                            }
                        Severity: Major
                        Found in wouso/resources/static/js/jquery.js - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                  if ( attrs[ i ] ) {
                                                      name = attrs[ i ].name;
                                                      if ( name.indexOf( "data-" ) === 0 ) {
                                                          name = jQuery.camelCase( name.slice(5) );
                                                          dataAttr( elem, name, data[ name ] );
                          Severity: Major
                          Found in wouso/resources/static/js/jquery.js - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                if ( conv && s[ "throws" ] ) {
                                                    response = conv( response );
                                                } else {
                                                    try {
                                                        response = conv( response );
                            Severity: Major
                            Found in wouso/resources/static/js/jquery.js - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                              if ( xhr.readyState !== 4 ) {
                                                                  xhr.abort();
                                                              }
                              Severity: Major
                              Found in wouso/resources/static/js/jquery.js - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                        if ( (elem = matcherOut[i]) ) {
                                                            // Restore matcherIn since elem is not yet a final match
                                                            temp.push( (matcherIn[i] = elem) );
                                                        }
                                Severity: Major
                                Found in wouso/resources/static/js/jquery.js - About 45 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language