rosedu/wouso

View on GitHub
wouso/core/god/god.py

Summary

Maintainability
C
1 day
Test Coverage

Function can_cast has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    def can_cast(self, spell, source, destination):
        """ Check if destination can receive spell from source

        Return: a tuple of (can_cast, error_message)
        """
Severity: Minor
Found in wouso/core/god/god.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function user_can_interact_with has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def user_can_interact_with(self, player_from, player_to, game=None):
        if game is not None:
            game = str(game.__name__)

        if game == 'ChallengeGame':
Severity: Minor
Found in wouso/core/god/god.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function post_cast has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def post_cast(sender, **kwargs):
    """ Execute action after a spell is cast. This is used to implement specific spells
    such as 'clean any existing spell' cast.

    Returns True if action has been taken, False if not.
Severity: Minor
Found in wouso/core/god/god.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return False, 'Player is cursed'
Severity: Major
Found in wouso/core/god/god.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return False, 'Player is cursed'
    Severity: Major
    Found in wouso/core/god/god.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return False, 'Something wrong'
      Severity: Major
      Found in wouso/core/god/god.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return False, 'Something wrong'
        Severity: Major
        Found in wouso/core/god/god.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return False, 'Player already has this spell cast on him'
          Severity: Major
          Found in wouso/core/god/god.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return True, None
            Severity: Major
            Found in wouso/core/god/god.py - About 30 mins to fix

              Function spell_cleanup has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              def spell_cleanup(spell, destination, spell_name):
                  """
                  This function eliminates same type spells with contrary sign +/-
                  """
                  existing = destination.magic.spells.filter(spell__name=spell_name)
              Severity: Minor
              Found in wouso/core/god/god.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function get_level_progress has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  def get_level_progress(self, player):
                      """ Get player progress inside its level """
                      level_no = player.level_no
                      points = player.points
                      level_limits = self.get_level_limits()
              Severity: Minor
              Found in wouso/core/god/god.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if spell.name == 'challenge-affect-scoring':
                          if not spell_cleanup(spell, destination, spell.name):
                              return False, 'Something wrong'
              Severity: Minor
              Found in wouso/core/god/god.py and 1 other location - About 40 mins to fix
              wouso/core/god/god.py on lines 176..178

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 34.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      if spell.name == 'challenge-affect-scoring-won':
                          if not spell_cleanup(spell, destination, spell.name):
                              return False, 'Something wrong'
              Severity: Minor
              Found in wouso/core/god/god.py and 1 other location - About 40 mins to fix
              wouso/core/god/god.py on lines 173..175

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 34.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Do not use bare 'except'
              Open

                      except:
              Severity: Minor
              Found in wouso/core/god/god.py by pep8

              When catching exceptions, mention specific exceptions when possible.

              Okay: except Exception:
              Okay: except BaseException:
              E722: except:

              Line too long (106 > 100 characters)
              Open

                      return dict(next_level=level_no + 1, points_gained=points_gained, points_left=next_limit - points,
              Severity: Minor
              Found in wouso/core/god/god.py by pep8

              Limit all lines to a maximum of 79 characters.

              There are still many devices around that are limited to 80 character
              lines; plus, limiting windows to 80 characters makes it possible to
              have several windows side-by-side.  The default wrapping on such
              devices looks ugly.  Therefore, please limit all lines to a maximum
              of 79 characters. For flowing long blocks of text (docstrings or
              comments), limiting the length to 72 characters is recommended.
              
              Reports error E501.

              Do not use bare 'except'
              Open

                  except:
              Severity: Minor
              Found in wouso/core/god/god.py by pep8

              When catching exceptions, mention specific exceptions when possible.

              Okay: except Exception:
              Okay: except BaseException:
              E722: except:

              Line too long (108 > 100 characters)
              Open

                                  player_from.get_extension(TopUser).position - player_to.get_extension(TopUser).position)
              Severity: Minor
              Found in wouso/core/god/god.py by pep8

              Limit all lines to a maximum of 79 characters.

              There are still many devices around that are limited to 80 character
              lines; plus, limiting windows to 80 characters makes it possible to
              have several windows side-by-side.  The default wrapping on such
              devices looks ugly.  Therefore, please limit all lines to a maximum
              of 79 characters. For flowing long blocks of text (docstrings or
              comments), limiting the length to 72 characters is recommended.
              
              Reports error E501.

              Line too long (102 > 100 characters)
              Open

                          dict(name='points-gold-rate', expression='points=-{points};gold={points}*0.1', owner=None,
              Severity: Minor
              Found in wouso/core/god/god.py by pep8

              Limit all lines to a maximum of 79 characters.

              There are still many devices around that are limited to 80 character
              lines; plus, limiting windows to 80 characters makes it possible to
              have several windows side-by-side.  The default wrapping on such
              devices looks ugly.  Therefore, please limit all lines to a maximum
              of 79 characters. For flowing long blocks of text (docstrings or
              comments), limiting the length to 72 characters is recommended.
              
              Reports error E501.

              Do not use bare 'except'
              Open

                      except:
              Severity: Minor
              Found in wouso/core/god/god.py by pep8

              When catching exceptions, mention specific exceptions when possible.

              Okay: except Exception:
              Okay: except BaseException:
              E722: except:

              Line too long (116 > 100 characters)
              Open

                      psdue.player.points = 1.0 * psdue.player.points * psdue.player.magic.modifier_percents('top-disguise') / 100
              Severity: Minor
              Found in wouso/core/god/god.py by pep8

              Limit all lines to a maximum of 79 characters.

              There are still many devices around that are limited to 80 character
              lines; plus, limiting windows to 80 characters makes it possible to
              have several windows side-by-side.  The default wrapping on such
              devices looks ugly.  Therefore, please limit all lines to a maximum
              of 79 characters. For flowing long blocks of text (docstrings or
              comments), limiting the length to 72 characters is recommended.
              
              Reports error E501.

              Closing bracket does not match visual indentation
              Open

                          ]
              Severity: Minor
              Found in wouso/core/god/god.py by pep8

              Continuation lines indentation.

              Continuation lines should align wrapped elements either vertically
              using Python's implicit line joining inside parentheses, brackets
              and braces, or using a hanging indent.
              
              When using a hanging indent these considerations should be applied:
              - there should be no arguments on the first line, and
              - further indentation should be used to clearly distinguish itself
                as a continuation line.
              
              Okay: a = (\n)
              E123: a = (\n    )
              
              Okay: a = (\n    42)
              E121: a = (\n   42)
              E122: a = (\n42)
              E123: a = (\n    42\n    )
              E124: a = (24,\n     42\n)
              E125: if (\n    b):\n    pass
              E126: a = (\n        42)
              E127: a = (24,\n      42)
              E128: a = (24,\n    42)
              E129: if (a or\n    b):\n    pass
              E131: a = (\n    42\n 24)

              Do not use bare 'except'
              Open

                  except:
              Severity: Minor
              Found in wouso/core/god/god.py by pep8

              When catching exceptions, mention specific exceptions when possible.

              Okay: except Exception:
              Okay: except BaseException:
              E722: except:

              There are no issues that match your filters.

              Category
              Status