Sign upLogin

rosedu/wouso

View on GitHub
Star
wouso/core/scoring/sm.py

Summary

Maintainability
C
1 day
Test Coverage

Function setup_scoring has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

def setup_scoring():

    """ Prepare database for Scoring """
    for cc in CORE_POINTS:
        if not Coin.get(cc):
Severity: Minor
Found in wouso/core/scoring/sm.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function score_simple has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

def score_simple(player, coin, amount, game=None, formula=None,
Severity: Major
Found in wouso/core/scoring/sm.py - About 50 mins to fix

    Function score has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def score(user, game, formula, external_id=None, percents=100, **params):
    Severity: Minor
    Found in wouso/core/scoring/sm.py - About 45 mins to fix

      Function history_for has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      def history_for(user, game, external_id=None, formula=None, coin=None):
      Severity: Minor
      Found in wouso/core/scoring/sm.py - About 35 mins to fix

        Function unset has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        def unset(user, game, formula, external_id=None, **params):
        Severity: Minor
        Found in wouso/core/scoring/sm.py - About 35 mins to fix

          Function timer has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def timer(user, game, formula, default=300, **params):
          Severity: Minor
          Found in wouso/core/scoring/sm.py - About 35 mins to fix

            Function update_points has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            def update_points(player, game):
    level = God.get_level_for_points(player.points)

    if level == player.level_no:
        return
            Severity: Minor
            Found in wouso/core/scoring/sm.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function score_simple has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            def score_simple(player, coin, amount, game=None, formula=None,
                 external_id=None, percents=100):

    """ Give amount of coin to the player.
    """
            Severity: Minor
            Found in wouso/core/scoring/sm.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function history_for has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            def history_for(user, game, external_id=None, formula=None, coin=None):
    """ Return all history entries for given (user, game) pair.
    """
    # TODO: check usage
    fltr = {}
            Severity: Minor
            Found in wouso/core/scoring/sm.py - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                result = History.objects.filter(user=player.user, coin=coin).aggregate(total=models.Sum('amount'))
            Severity: Minor
            Found in wouso/core/scoring/sm.py and 1 other location - About 40 mins to fix
            wouso/core/scoring/sm.py on lines 262..262

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 34.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                result = History.objects.filter(user=player.user, coin=coin).aggregate(total=models.Sum('amount'))
            Severity: Minor
            Found in wouso/core/scoring/sm.py and 1 other location - About 40 mins to fix
            wouso/core/scoring/sm.py on lines 270..270

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 34.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                for game in get_games():
        for formula in game.get_formulas():
            if not Formula.get(formula):
                Formula.add(formula)
            Severity: Minor
            Found in wouso/core/scoring/sm.py and 1 other location - About 35 mins to fix
            wouso/core/scoring/sm.py on lines 70..72

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 33.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                for formula in God.get_system_formulas():
        if not Formula.get(formula):
            Formula.add(formula)
            Severity: Minor
            Found in wouso/core/scoring/sm.py and 1 other location - About 35 mins to fix
            wouso/core/scoring/sm.py on lines 65..68

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 33.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Line too long (102 > 100 characters)
            Open

                result = History.objects.filter(user=player.user, coin=coin).aggregate(total=models.Sum('amount'))
            Severity: Minor
            Found in wouso/core/scoring/sm.py by pep8

            Limit all lines to a maximum of 79 characters.

            There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

            Line too long (106 > 100 characters)
            Open

                        computed_amount = 1.0 * computed_amount * player.magic.modifier_percents('top-disguise') / 100
            Severity: Minor
            Found in wouso/core/scoring/sm.py by pep8

            Limit all lines to a maximum of 79 characters.

            There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

            Expected 2 blank lines after class or function definition, found 1
            Open

            signals.addActivity.connect(first_login_check)
            Severity: Minor
            Found in wouso/core/scoring/sm.py by pep8

            Separate top-level function and class definitions with two blank lines.

            Method definitions inside a class are separated by a single blank
line.

Extra blank lines may be used (sparingly) to separate groups of
related functions.  Blank lines may be omitted between a bunch of
related one-liners (e.g. a set of dummy implementations).

Use blank lines in functions, sparingly, to indicate logical
sections.

Okay: def a():\n    pass\n\n\ndef b():\n    pass
Okay: def a():\n    pass\n\n\nasync def b():\n    pass
Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
Okay: default = 1\nfoo = 1
Okay: classify = 1\nfoo = 1

E301: class Foo:\n    b = 0\n    def bar():\n        pass
E302: def a():\n    pass\n\ndef b(n):\n    pass
E302: def a():\n    pass\n\nasync def b(n):\n    pass
E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
E303: def a():\n\n\n\n    pass
E304: @decorator\n\ndef a():\n    pass
E305: def a():\n    pass\na()
E306: def a():\n    def b():\n        pass\n    def c():\n        pass

            Line too long (102 > 100 characters)
            Open

                result = History.objects.filter(user=player.user, coin=coin).aggregate(total=models.Sum('amount'))
            Severity: Minor
            Found in wouso/core/scoring/sm.py by pep8

            Limit all lines to a maximum of 79 characters.

            There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

            Block comment should start with '# '
            Open

                    #logging.exception(e)
            Severity: Minor
            Found in wouso/core/scoring/sm.py by pep8

            Separate inline comments by at least two spaces.

            An inline comment is a comment on the same line as a statement.
Inline comments should be separated by at least two spaces from the
statement. They should start with a # and a single space.

Each line of a block comment starts with a # and a single space
(unless it is indented text inside the comment).

Okay: x = x + 1  # Increment x
Okay: x = x + 1    # Increment x
Okay: # Block comment
E261: x = x + 1 # Increment x
E262: x = x + 1  #Increment x
E262: x = x + 1  #  Increment x
E265: #Block comment
E266: ### Block comment

            Line too long (121 > 100 characters)
            Open

                for history in History.objects.filter(user=user, game=game.get_instance(), formula=formula, external_id=external_id):
            Severity: Minor
            Found in wouso/core/scoring/sm.py by pep8

            Limit all lines to a maximum of 79 characters.

            There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

            There are no issues that match your filters.

            Category
            Status