rposborne/gitquickbooks

View on GitHub

Showing 8 of 8 total issues

Assignment Branch Condition size for process is too high. [98.68/20]
Open

    def process
      path = File.expand_path(options.file)
      start_date = Date.parse(options.start_on)
      end_date = Date.today

Severity: Minor
Found in lib/gitquickbooks/cli.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method process has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def process
      path = File.expand_path(options.file)
      start_date = Date.parse(options.start_on)
      end_date = Date.today

Severity: Major
Found in lib/gitquickbooks/cli.rb - About 2 hrs to fix

    Method process has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        def process
          path = File.expand_path(options.file)
          start_date = Date.parse(options.start_on)
          end_date = Date.today
    
    
    Severity: Minor
    Found in lib/gitquickbooks/cli.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Do not suppress exceptions.
    Open

    rescue LoadError
    Severity: Minor
    Found in Rakefile by rubocop

    This cop checks for rescue blocks with no body.

    Example:

    # bad
    
    def some_method
      do_something
    rescue
      # do nothing
    end

    Example:

    # bad
    
    begin
      do_something
    rescue
      # do nothing
    end

    Example:

    # good
    
    def some_method
      do_something
    rescue
      handle_exception
    end

    Example:

    # good
    
    begin
      do_something
    rescue
      handle_exception
    end

    FIXME found
    Open

                     (TODO, FIXME, OPTIMIZE, HACK, REVIEW).
    Severity: Minor
    Found in .rubocop.yml by fixme

    HACK found
    Open

                     (TODO, FIXME, OPTIMIZE, HACK, REVIEW).
    Severity: Minor
    Found in .rubocop.yml by fixme

    TODO found
    Open

    TODO: Write usage instructions here
    Severity: Minor
    Found in README.md by fixme

    TODO found
    Open

                     (TODO, FIXME, OPTIMIZE, HACK, REVIEW).
    Severity: Minor
    Found in .rubocop.yml by fixme
    Severity
    Category
    Status
    Source
    Language