Sign upLogin

rpush/rpush

View on GitHub
Star
lib/rpush/daemon/store/active_record.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Class ActiveRecord has 24 methods (exceeds 20 allowed). Consider refactoring.
Open

      class ActiveRecord
        include Reconnectable

        DEFAULT_MARK_OPTIONS = { persist: true }
Severity: Minor
Found in lib/rpush/daemon/store/active_record.rb - About 2 hrs to fix

    Method adapter_name has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

            def adapter_name
          env = (defined?(Rails) && Rails.env) ? Rails.env : 'development'
          if ::ActiveRecord::VERSION::MAJOR > 6
            ::ActiveRecord::Base.configurations.configs_for(env_name: env).first.configuration_hash[:adapter]
          else
    Severity: Minor
    Found in lib/rpush/daemon/store/active_record.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create_gcm_like_notification has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            def create_gcm_like_notification(notification, attrs, data, registration_ids, deliver_after, app) # rubocop:disable Metrics/ParameterLists
    Severity: Minor
    Found in lib/rpush/daemon/store/active_record.rb - About 45 mins to fix

      Method mark_failed has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              def mark_failed(notification, code, description, time, opts = {})
      Severity: Minor
      Found in lib/rpush/daemon/store/active_record.rb - About 35 mins to fix

        Method create_adm_notification has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                def create_adm_notification(attrs, data, registration_ids, deliver_after, app)
        Severity: Minor
        Found in lib/rpush/daemon/store/active_record.rb - About 35 mins to fix

          Method create_gcm_notification has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  def create_gcm_notification(attrs, data, registration_ids, deliver_after, app)
          Severity: Minor
          Found in lib/rpush/daemon/store/active_record.rb - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status