Sign upLogin

rqueensen/faludi-lca-app

View on GitHub
Star

Showing 12 of 12 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    $('#material-search').keyup(function() {
        var input = $('#material-search').val();
        var categories = '#material-dropdown .collapsible';
        var materials = '#material-dropdown .collapsible .draggable';
        $(categories).hide();
Severity: Major
Found in app/assets/javascripts/model.js and 1 other location - About 5 hrs to fix
app/assets/javascripts/model.js on lines 268..276

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 140.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    $('#manufacturing-search').keyup(function() {
        var input = $('#manufacturing-search').val();
        var categories = '#manufacturing-dropdown .collapsible';
        var materials = '#manufacturing-dropdown .collapsible .draggable';
        $(categories).hide();
Severity: Major
Found in app/assets/javascripts/model.js and 1 other location - About 5 hrs to fix
app/assets/javascripts/model.js on lines 258..266

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 140.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method signup has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

   def signup
      if request.xhr?
         flash[:ajax] = true
      else
         flash[:ajax] = false
Severity: Minor
Found in app/controllers/users_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function make_new_material_section has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function make_new_material_section(name, id, quantity, measurement) {
    quantity = typeof quantity !== 'undefined' ? quantity : 0;
    measurement = typeof measurement !== 'undefined' ? measurement : "kg";

    var $li = $('<li></li>', {
Severity: Minor
Found in app/assets/javascripts/model.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

       $('#login_button').click(function(e){
      runAnim('fadeOutDown');
      success_call = function(result){
        $("#loadcontent").html(result);
      };
    Severity: Major
    Found in app/assets/javascripts/users.js and 1 other location - About 1 hr to fix
    app/assets/javascripts/users.js on lines 34..40

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

       $('#signup_button').click(function(e){
      runAnim('fadeOutDown');
      success_call = function(result){
        $("#loadcontent").html(result);
      };
    Severity: Major
    Found in app/assets/javascripts/users.js and 1 other location - About 1 hr to fix
    app/assets/javascripts/users.js on lines 26..32

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 65.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method index has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def index
   #  before_action :authenticate_user!
    if session[:user_id] == nil
      puts "USER is NIL"
      # For Testing Purposes
    Severity: Minor
    Found in app/controllers/model_controller.rb - About 1 hr to fix

      Method signup has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

         def signup
      if request.xhr?
         flash[:ajax] = true
      else
         flash[:ajax] = false
      Severity: Minor
      Found in app/controllers/users_controller.rb - About 1 hr to fix

        Method index has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def index
   #  before_action :authenticate_user!
    if session[:user_id] == nil
      puts "USER is NIL"
      # For Testing Purposes
        Severity: Minor
        Found in app/controllers/model_controller.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function make_new_material_section has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        function make_new_material_section(name, id, quantity, measurement) {
    quantity = typeof quantity !== 'undefined' ? quantity : 0;
    measurement = typeof measurement !== 'undefined' ? measurement : "kg";

    var $li = $('<li></li>', {
        Severity: Minor
        Found in app/assets/javascripts/model.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function add_proc_to has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function add_proc_to($mat, name, id, quantity, measurement) {
        Severity: Minor
        Found in app/assets/javascripts/model.js - About 35 mins to fix

          Method login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

             def login
      if request.xhr?
         flash[:ajax] = true
      else
         flash[:ajax] = false
          Severity: Minor
          Found in app/controllers/users_controller.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language