Sign upLogin

rqueensen/faludi-lca-app

View on GitHub
Star

Showing 8 of 12 total issues

Method signup has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

   def signup
      if request.xhr?
         flash[:ajax] = true
      else
         flash[:ajax] = false
Severity: Minor
Found in app/controllers/users_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function make_new_material_section has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function make_new_material_section(name, id, quantity, measurement) {
    quantity = typeof quantity !== 'undefined' ? quantity : 0;
    measurement = typeof measurement !== 'undefined' ? measurement : "kg";

    var $li = $('<li></li>', {
Severity: Minor
Found in app/assets/javascripts/model.js - About 1 hr to fix

    Method index has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def index
   #  before_action :authenticate_user!
    if session[:user_id] == nil
      puts "USER is NIL"
      # For Testing Purposes
    Severity: Minor
    Found in app/controllers/model_controller.rb - About 1 hr to fix

      Method signup has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

         def signup
      if request.xhr?
         flash[:ajax] = true
      else
         flash[:ajax] = false
      Severity: Minor
      Found in app/controllers/users_controller.rb - About 1 hr to fix

        Method index has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def index
   #  before_action :authenticate_user!
    if session[:user_id] == nil
      puts "USER is NIL"
      # For Testing Purposes
        Severity: Minor
        Found in app/controllers/model_controller.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function make_new_material_section has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        function make_new_material_section(name, id, quantity, measurement) {
    quantity = typeof quantity !== 'undefined' ? quantity : 0;
    measurement = typeof measurement !== 'undefined' ? measurement : "kg";

    var $li = $('<li></li>', {
        Severity: Minor
        Found in app/assets/javascripts/model.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function add_proc_to has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function add_proc_to($mat, name, id, quantity, measurement) {
        Severity: Minor
        Found in app/assets/javascripts/model.js - About 35 mins to fix

          Method login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

             def login
      if request.xhr?
         flash[:ajax] = true
      else
         flash[:ajax] = false
          Severity: Minor
          Found in app/controllers/users_controller.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language