Sign upLogin

rr/rr

View on GitHub
Star
lib/rr/expectations/argument_equality_expectation.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method wildcard_match? has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

      def wildcard_match?(arguments, keyword_arguments)
        return false unless arguments.length == expected_arguments.length
        arguments.each_with_index do |arg, index|
          expected_argument = expected_arguments[index]
          if expected_argument.respond_to?(:wildcard_match?)
Severity: Minor
Found in lib/rr/expectations/argument_equality_expectation.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method wildcard_match? has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def wildcard_match?(arguments, keyword_arguments)
        return false unless arguments.length == expected_arguments.length
        arguments.each_with_index do |arg, index|
          expected_argument = expected_arguments[index]
          if expected_argument.respond_to?(:wildcard_match?)
Severity: Minor
Found in lib/rr/expectations/argument_equality_expectation.rb - About 1 hr to fix

    Method exact_match? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def exact_match?(arguments, keyword_arguments)
        return false unless arguments.length == expected_arguments.length
        arguments.each_with_index do |arg, index|
          expected_arg = expected_arguments[index]
          return false unless self.class.recursive_safe_eq(expected_arg, arg)
    Severity: Minor
    Found in lib/rr/expectations/argument_equality_expectation.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                  return false
    Severity: Major
    Found in lib/rr/expectations/argument_equality_expectation.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                    return false
      Severity: Major
      Found in lib/rr/expectations/argument_equality_expectation.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status