rspec/rspec-rails

View on GitHub
lib/rspec/rails/matchers/active_job.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Class Base has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

        class Base < RSpec::Rails::Matchers::BaseMatcher
          def initialize
            @args = []
            @queue = nil
            @at = nil
Severity: Minor
Found in lib/rspec/rails/matchers/active_job.rb - About 3 hrs to fix

    File active_job.rb has 260 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require "active_job/base"
    require "active_job/arguments"
    
    module RSpec
      module Rails
    Severity: Minor
    Found in lib/rspec/rails/matchers/active_job.rb - About 2 hrs to fix

      Method base_message has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

                def base_message
                  "#{message_expectation_modifier} #{@expected_number} jobs,".tap do |msg|
                    msg << " with #{@args}," if @args.any?
                    msg << " on queue #{@queue}," if @queue
                    msg << " at #{@at.inspect}," if @at
      Severity: Minor
      Found in lib/rspec/rails/matchers/active_job.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method at_match? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

                def at_match?(job)
                  return true unless @at
                  return job[:at].nil? if @at == :no_wait
                  return false unless job[:at]
      
      
      Severity: Minor
      Found in lib/rspec/rails/matchers/active_job.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status