Sign upLogin

rtopitt/bolao2014

View on GitHub
Star
app/models/match.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method result has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def result
    return unless valid? && scorable?
    if goals_a == goals_b
      if drawable?
        :draw
Severity: Minor
Found in app/models/match.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method no_draw_after_group_phase has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def no_draw_after_group_phase
    return unless with_known_teams? && with_known_goals? && !drawable?
    if goals_draw?
      if !with_known_penalty_goals?
        errors.add(:penalty_goals_a, :blank)
Severity: Minor
Found in app/models/match.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method scorable? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def scorable?
    return false unless locked?
    return false unless with_known_teams?
    return false unless with_known_goals?
    return false if goals_draw? && !drawable? && !with_known_penalty_goals?
Severity: Minor
Found in app/models/match.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status