Sign upLogin

rtopitt/bolao2014

View on GitHub
Star
app/models/payment_updater.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method update! has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def update!
    set_payment_attributes_from_transaction
    if valid_status_change?
      payment.save!
      if status_changed?
Severity: Minor
Found in app/models/payment_updater.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method set_payment_attributes_from_transaction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def set_payment_attributes_from_transaction
    payment.transaction_code = transaction_code_from_transaction if payment.transaction_code.blank?
    payment.status = status_from_transaction
    @next_payment_status = payment.status
    unless (@next_payment_status.initiated? || @next_payment_status.waiting_payment? || @next_payment_status.in_analysis?)
Severity: Minor
Found in app/models/payment_updater.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status