rubinius/rubinius

View on GitHub
build/scripts/dependency_grapher.rb

Summary

Maintainability
C
1 day
Test Coverage

File dependency_grapher.rb has 366 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'set'

module Daedalus
class DependencyGrapher
  DEV_NULL = RUBY_PLATFORM =~ /mingw|mswin/ ? 'NUL' : '/dev/null'
Severity: Minor
Found in build/scripts/dependency_grapher.rb - About 4 hrs to fix

    Method evaluate has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        def evaluate(defines)
          # Stage0: eliminate comments
          @expression.gsub!(/(\/\/.*)$/, "")
          @expression.gsub!(/(\/\*.*\*\/)/, "")
    
    
    Severity: Minor
    Found in build/scripts/dependency_grapher.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method evaluate has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def evaluate(defines)
          # Stage0: eliminate comments
          @expression.gsub!(/(\/\/.*)$/, "")
          @expression.gsub!(/(\/\*.*\*\/)/, "")
    
    
    Severity: Minor
    Found in build/scripts/dependency_grapher.rb - About 1 hr to fix

      Method parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def parse(lines)
            @line = 0
      
            re = /^\s*#(include|ifdef|ifndef|endif|else|define|undef|if|elif)(.*)$/o
            full_line = ""
      Severity: Minor
      Found in build/scripts/dependency_grapher.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status