Sign upLogin

rubinius/rubinius

View on GitHub
Star
core/argf.rb

Summary

Maintainability
D
2 days
Test Coverage

Class ARGFClass has 35 methods (exceeds 20 allowed). Consider refactoring.
Open

  class ARGFClass
    include Enumerable

    # :internal:
    #
Severity: Minor
Found in core/argf.rb - About 4 hrs to fix

    Method read has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
    Open

        def read(bytes=nil, output=nil)
      # The user might try to pass in nil, so we have to check here
      output ||= default_value
      output.clear
    Severity: Minor
    Found in core/argf.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File argf.rb has 290 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Rubinius

  # :internal:
  #
  # The virtual concatenation file of the files given on command line (or
    Severity: Minor
    Found in core/argf.rb - About 2 hrs to fix

      Method advance! has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          def advance!
      return true unless @advance

      unless @init
      Severity: Minor
      Found in core/argf.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method gets has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          def gets(sep=$/)
      while true
        return nil unless advance!
        line = @stream.gets(sep)
      Severity: Minor
      Found in core/argf.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getbyte has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def getbyte
      while true
        return nil unless advance!
        if val = @stream.getbyte
          return val
      Severity: Minor
      Found in core/argf.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getc has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          def getc
      while true
        return nil unless advance!
        if val = @stream.getc
          return val
      Severity: Minor
      Found in core/argf.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method read_nonblock has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def read_nonblock(maxlen, output = nil, exception: true)
      output ||= default_value

      unless advance!
        output.clear
      Severity: Minor
      Found in core/argf.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method readpartial has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def readpartial(maxlen, output=nil)
      output ||= default_value

      unless advance!
        output.clear
      Severity: Minor
      Found in core/argf.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def getc
      while true
        return nil unless advance!
        if val = @stream.getc
          return val
      Severity: Minor
      Found in core/argf.rb and 1 other location - About 15 mins to fix
      core/argf.rb on lines 199..208

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def getbyte
      while true
        return nil unless advance!
        if val = @stream.getbyte
          return val
      Severity: Minor
      Found in core/argf.rb and 1 other location - About 15 mins to fix
      core/argf.rb on lines 218..227

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 26.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status