Sign upLogin

rubinius/rubinius

View on GitHub
Star
core/hash.rb

Summary

Maintainability
F
4 days
Test Coverage

File hash.rb has 762 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class Hash
  include Enumerable

  Vector = Rubinius::Tuple
Severity: Major
Found in core/hash.rb - About 1 day to fix

    Class Hash has 60 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Hash
  include Enumerable

  Vector = Rubinius::Tuple
    Severity: Major
    Found in core/hash.rb - About 1 day to fix

      Method [] has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.[](*args)
    total = args.size
    if total == 1
      obj = args.first
      if hash = Rubinius::Type.check_convert_type(obj, Hash, :to_hash)
      Severity: Minor
      Found in core/hash.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method == has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

        def ==(other)
    return true if self.equal? other

    unless other.kind_of? Hash
      return false unless other.respond_to? :to_hash
      Severity: Minor
      Found in core/hash.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method eql? has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

        def eql?(other)
    return true if self.equal? other

    unless other.kind_of? Hash
      return false unless other.respond_to? :to_hash
      Severity: Minor
      Found in core/hash.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method merge! has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        def merge!(other)
    Rubinius.check_frozen

    other = Rubinius::Type.coerce_to other, Hash, :to_hash
      Severity: Minor
      Found in core/hash.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method [] has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.[](*args)
    total = args.size
    if total == 1
      obj = args.first
      if hash = Rubinius::Type.check_convert_type(obj, Hash, :to_hash)
      Severity: Minor
      Found in core/hash.rb - About 1 hr to fix

        Method from_item has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def self.from_item(state, level, item, key, key_hash, value)
        Severity: Minor
        Found in core/hash.rb - About 45 mins to fix

          Method add_item has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def add_item(state, item, key, key_hash, value)
          Severity: Minor
          Found in core/hash.rb - About 35 mins to fix

            Method add has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def add(state, item, key, key_hash, value)
            Severity: Minor
            Found in core/hash.rb - About 35 mins to fix

              Method delete has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                def delete(key)
    Rubinius.check_frozen

    if @trie
      Rubinius.privately { key_hash = key.hash }
              Severity: Minor
              Found in core/hash.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method select! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                def select!
    return to_enum(:select!) { size } unless block_given?

    Rubinius.check_frozen
              Severity: Minor
              Found in core/hash.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method delete has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  def delete(state, key, key_hash)
      if state.match? @key, @key_hash, key, key_hash

        if @previous
          @previous.next = @next
              Severity: Minor
              Found in core/hash.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid too many return statements within this method.
              Open

                      return false unless item = @trie.lookup(@state, e.key, key_hash)
              Severity: Major
              Found in core/hash.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return false unless item
                Severity: Major
                Found in core/hash.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return false unless item.value.eql?(e.value)
                  Severity: Major
                  Found in core/hash.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                              return false
                    Severity: Major
                    Found in core/hash.rb - About 30 mins to fix

                      Method fetch has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def fetch(key, default=undefined)
    if @trie
      Rubinius.privately { key_hash = key.hash }
      if item = @trie.lookup(@state, key, key_hash)
        return item.value
                      Severity: Minor
                      Found in core/hash.rb - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method reject! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def reject!(&block)
    return to_enum(:reject!) { size } unless block_given?

    Rubinius.check_frozen
                      Severity: Minor
                      Found in core/hash.rb - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method values_at has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def values_at(*args)
    if empty?
      args.map { |key| default key }
    else
      args.map do |key|
                      Severity: Minor
                      Found in core/hash.rb - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        def dig(key, *remaining_keys)
    item = self[key]
    return item if remaining_keys.empty? || item.nil?

    raise TypeError, "#{item.class} does not have #dig method" unless item.respond_to?(:dig)
                      Severity: Minor
                      Found in core/hash.rb and 1 other location - About 25 mins to fix
                      core/array.rb on lines 721..727

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 29.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status