Sign upLogin

rubinius/rubinius

View on GitHub
Star
core/match_data.rb

Summary

Maintainability
C
1 day
Test Coverage

Method [] has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  def [](idx, len = nil)
    return to_a[idx, len] if len

    case idx
    when Fixnum
Severity: Minor
Found in core/match_data.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Class MatchData has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

class MatchData
  def begin(idx)
    if idx == 0
      start = @full.at(0)
    else
Severity: Minor
Found in core/match_data.rb - About 2 hrs to fix

    Method [] has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def [](idx, len = nil)
    return to_a[idx, len] if len

    case idx
    when Fixnum
    Severity: Minor
    Found in core/match_data.rb - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

              return self[idx.to_sym]
      Severity: Major
      Found in core/match_data.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return @source.byteslice(x, y-x)
        Severity: Major
        Found in core/match_data.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                    return nil
          Severity: Major
          Found in core/match_data.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                return to_a[idx]
            Severity: Major
            Found in core/match_data.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return val if val
              Severity: Major
              Found in core/match_data.rb - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  def begin(idx)
    if idx == 0
      start = @full.at(0)
    else
      start = @region.at(idx - 1).at(0)
                Severity: Minor
                Found in core/match_data.rb and 1 other location - About 30 mins to fix
                core/match_data.rb on lines 13..21

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 33.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  def end(idx)
    if idx == 0
      fin = @full.at(1)
    else
      fin = @region.at(idx - 1).at(1)
                Severity: Minor
                Found in core/match_data.rb and 1 other location - About 30 mins to fix
                core/match_data.rb on lines 2..10

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 33.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status