Sign upLogin

rubinius/rubinius

View on GitHub
Star
core/rational.rb

Summary

Maintainability
D
2 days
Test Coverage

Method ** has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

  def **(other)
    if other.kind_of?(Rational) && other.denominator == 1
      other = other.numerator
    end
Severity: Minor
Found in core/rational.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File rational.rb has 314 lines of code (exceeds 250 allowed). Consider refactoring.
Open

class Rational < Numeric
  attr_reader :numerator
  attr_reader :denominator

  def *(other)
Severity: Minor
Found in core/rational.rb - About 3 hrs to fix

    Class Rational has 26 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Rational < Numeric
  attr_reader :numerator
  attr_reader :denominator

  def *(other)
    Severity: Minor
    Found in core/rational.rb - About 3 hrs to fix

      Method reduce has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.reduce(num, den, mathn = true)
    case num
    when Integer
      # nothing
    when Numeric
      Severity: Minor
      Found in core/rational.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method ** has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def **(other)
    if other.kind_of?(Rational) && other.denominator == 1
      other = other.numerator
    end
      Severity: Minor
      Found in core/rational.rb - About 1 hr to fix

        Method reduce has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def self.reduce(num, den, mathn = true)
    case num
    when Integer
      # nothing
    when Numeric
        Severity: Minor
        Found in core/rational.rb - About 1 hr to fix

          Method convert has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            def self.convert(num, den, mathn = true)
    if num.nil? || den.nil?
      raise TypeError, "cannot convert nil into Rational"
    end
          Severity: Minor
          Found in core/rational.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method round has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def round(precision = 0)
    return with_precision(:round, precision) unless precision == 0
    return 0 if @numerator == 0
    return @numerator if @denominator == 1
          Severity: Minor
          Found in core/rational.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def +(other)
    case other
    when Rational
      num = @numerator * other.denominator + @denominator * other.numerator
      den = @denominator * other.denominator
          Severity: Major
          Found in core/rational.rb and 1 other location - About 1 hr to fix
          core/rational.rb on lines 88..100

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def -(other)
    case other
    when Rational
      num = @numerator * other.denominator - @denominator * other.numerator
      den = @denominator * other.denominator
          Severity: Major
          Found in core/rational.rb and 1 other location - About 1 hr to fix
          core/rational.rb on lines 72..84

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status