Sign upLogin

rubinius/rubinius

View on GitHub
Star
core/splitter.rb

Summary

Maintainability
D
1 day
Test Coverage

Method split has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

    def self.split(string, pattern, limit)
      # Odd edge case
      return [] if string.empty?

      tail_empty = false
Severity: Minor
Found in core/splitter.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method split has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.split(string, pattern, limit)
      # Odd edge case
      return [] if string.empty?

      tail_empty = false
Severity: Major
Found in core/splitter.rb - About 3 hrs to fix

    Method split_on_string has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def self.split_on_string(string, pattern, trim_end)
      pos = 0

      ret = []
    Severity: Minor
    Found in core/splitter.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return split_on_string(string, pattern, trim_end)
    Severity: Major
    Found in core/splitter.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return split_characters(string, pattern, limited && limit, tail_empty)
      Severity: Major
      Found in core/splitter.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status