Sign upLogin

rubinius/rubinius

View on GitHub
Star
core/thread.rb

Summary

Maintainability
D
1 day
Test Coverage

Class Thread has 50 methods (exceeds 20 allowed). Consider refactoring.
Open

class Thread
  attr_reader :recursive_objects
  attr_reader :pid
  attr_reader :exception
  attr_reader :stack_size
Severity: Minor
Found in core/thread.rb - About 7 hrs to fix

    File thread.rb has 328 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class Thread
  attr_reader :recursive_objects
  attr_reader :pid
  attr_reader :exception
  attr_reader :stack_size
    Severity: Minor
    Found in core/thread.rb - About 3 hrs to fix

      Method raise has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def raise(exc=undefined, msg=nil, trace=nil)
    return self unless alive?

    if exc.respond_to? :exception
      exc = exc.exception msg
      Severity: Minor
      Found in core/thread.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method detect_recursion has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def self.detect_recursion(obj, paired_obj=undefined)
    id = obj.object_id
    pair_id = paired_obj.object_id
    objects = current.recursive_objects
      Severity: Minor
      Found in core/thread.rb - About 1 hr to fix

        Method detect_outermost_recursion has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.detect_outermost_recursion(obj, paired_obj=undefined, &block)
    rec = current.recursive_objects

    if rec[:__detect_outermost_recursion__]
      if detect_recursion(obj, paired_obj, &block)
        Severity: Minor
        Found in core/thread.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

              code = tup[0]
      line = tup[1]
      is_block = tup[2]
      name = tup[3]
        Severity: Minor
        Found in core/thread.rb and 1 other location - About 20 mins to fix
        core/kernel.rb on lines 382..387

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status