Sign upLogin

rubinius/rubinius

View on GitHub
Star
library/rubygems/dependency_resolver.rb

Summary

Maintainability
C
1 day
Test Coverage

Method resolve_for has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

  def resolve_for needed, specs
    while needed
      dep = needed.value
      needed = needed.tail
Severity: Minor
Found in library/rubygems/dependency_resolver.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method resolve_for has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def resolve_for needed, specs
    while needed
      dep = needed.value
      needed = needed.tail
Severity: Major
Found in library/rubygems/dependency_resolver.rb - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                return res unless res.for_spec? s
    Severity: Major
    Found in library/rubygems/dependency_resolver.rb - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status