rubinius/rubinius

View on GitHub
library/rubygems/resolver/molinillo/lib/molinillo/resolution.rb

Summary

Maintainability
D
1 day
Test Coverage

File resolution.rb has 320 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Gem::Resolver::Molinillo
  class Resolver
    # A specific resolution from a given {Resolver}
    class Resolution
      # A conflict that the resolution process encountered
Severity: Minor
Found in library/rubygems/resolver/molinillo/lib/molinillo/resolution.rb - About 3 hrs to fix

    Class Resolution has 30 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Resolution
          # A conflict that the resolution process encountered
          # @attr [Object] requirement the requirement that immediately led to the conflict
          # @attr [{String,Nil=>[Object]}] requirements the requirements that caused the conflict
          # @attr [Object, nil] existing the existing spec that was in conflict with
    Severity: Minor
    Found in library/rubygems/resolver/molinillo/lib/molinillo/resolution.rb - About 3 hrs to fix

      Method resolve has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

            def resolve
              start_resolution
      
              while state
                break unless state.requirements.any? || state.requirement
      Severity: Minor
      Found in library/rubygems/resolver/molinillo/lib/molinillo/resolution.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method state_index_for_unwind has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

            def state_index_for_unwind
              current_requirement = requirement
              existing_requirement = requirement_for_existing_name(name)
              index = -1
              [current_requirement, existing_requirement].each do |r|
      Severity: Minor
      Found in library/rubygems/resolver/molinillo/lib/molinillo/resolution.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method fixup_swapped_children has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def fixup_swapped_children(vertex) # rubocop:disable Metrics/CyclomaticComplexity
              payload = vertex.payload
              deps = dependencies_for(payload).group_by(&method(:name_for))
              vertex.outgoing_edges.each do |outgoing_edge|
                requirement = outgoing_edge.requirement
      Severity: Minor
      Found in library/rubygems/resolver/molinillo/lib/molinillo/resolution.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method process_topmost_state has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def process_topmost_state
              if possibility
                attempt_to_activate
              else
                create_conflict if state.is_a? PossibilityState
      Severity: Minor
      Found in library/rubygems/resolver/molinillo/lib/molinillo/resolution.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method unwind_for_conflict has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def unwind_for_conflict
              debug(depth) { "Unwinding for conflict: #{requirement} to #{state_index_for_unwind / 2}" }
              conflicts.tap do |c|
                sliced_states = states.slice!((state_index_for_unwind + 1)..-1)
                raise VersionConflict.new(c) unless state
      Severity: Minor
      Found in library/rubygems/resolver/molinillo/lib/molinillo/resolution.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method parent_of has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def parent_of(requirement)
              return unless requirement
              return unless index = @parents_of[requirement].last
              return unless parent_state = @states[index]
              parent_state.requirement
      Severity: Minor
      Found in library/rubygems/resolver/molinillo/lib/molinillo/resolution.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method indicate_progress has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def indicate_progress
              @iteration_counter += 1
              @progress_rate ||= resolver_ui.progress_rate
              if iteration_rate.nil?
                if Time.now - started_at >= @progress_rate
      Severity: Minor
      Found in library/rubygems/resolver/molinillo/lib/molinillo/resolution.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method create_conflict has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def create_conflict
              vertex = activated.vertex_named(name)
              locked_requirement = locked_requirement_named(name)
      
              requirements = {}
      Severity: Minor
      Found in library/rubygems/resolver/molinillo/lib/molinillo/resolution.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status