rubinius/rubinius

View on GitHub
library/rubygems/server.rb

Summary

Maintainability
D
2 days
Test Coverage

File server.rb has 638 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'webrick'
require 'zlib'
require 'erb'
require 'uri'

Severity: Major
Found in library/rubygems/server.rb - About 1 day to fix

    Method root has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def root(req, res)
        reset_gems
    
        add_date res
    
    
    Severity: Major
    Found in library/rubygems/server.rb - About 2 hrs to fix

      Method run has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def run
          listen
      
          WEBrick::Daemon.start if @daemon
      
      
      Severity: Minor
      Found in library/rubygems/server.rb - About 1 hr to fix

        Method root has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def root(req, res)
            reset_gems
        
            add_date res
        
        
        Severity: Minor
        Found in library/rubygems/server.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method show_rdoc_for_pattern has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def show_rdoc_for_pattern(pattern, res)
            found_gems = Dir.glob("{#{@gem_dirs.join ','}}/doc/#{pattern}").select {|path|
              File.exist? File.join(path, 'rdoc/index.html')
            }
            case found_gems.length
        Severity: Minor
        Found in library/rubygems/server.rb - About 1 hr to fix

          Method listen has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            def listen addresses = @addresses
              addresses = [nil] unless addresses
          
              listeners = 0
          
          
          Severity: Minor
          Found in library/rubygems/server.rb - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def initialize(gem_dirs, port, daemon, launch = nil, addresses = nil)
          Severity: Minor
          Found in library/rubygems/server.rb - About 35 mins to fix

            There are no issues that match your filters.

            Category
            Status