Sign upLogin

rubinius/rubinius

View on GitHub
Star
library/rubygems/user_interaction.rb

Summary

Maintainability
C
7 hrs
Test Coverage

File user_interaction.rb has 335 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'rubygems/util'

##
# Module that defines the default UserInteraction.  Any class including this
# module will have access to the +ui+ method that returns the default UI.
Severity: Minor
Found in library/rubygems/user_interaction.rb - About 4 hrs to fix

    Method _gets_noecho has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      def _gets_noecho
    require_io_console
    if IO.method_defined?(:noecho) then
      @ins.noecho {@ins.gets}
    elsif Gem.win_platform?
    Severity: Minor
    Found in library/rubygems/user_interaction.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method ask_yes_no has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def ask_yes_no(question, default=nil)
    unless tty? then
      if default.nil? then
        raise Gem::OperationNotSupportedError,
              "Not connected to a tty and no default specified"
    Severity: Minor
    Found in library/rubygems/user_interaction.rb - About 1 hr to fix

      Method ask_yes_no has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def ask_yes_no(question, default=nil)
    unless tty? then
      if default.nil? then
        raise Gem::OperationNotSupportedError,
              "Not connected to a tty and no default specified"
      Severity: Minor
      Found in library/rubygems/user_interaction.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status