Sign upLogin

rubinius/rubinius

View on GitHub
Star
mspec/lib/mspec/utils/options.rb

Summary

Maintainability
D
3 days
Test Coverage

File options.rb has 379 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'mspec/version'

class MSpecOption
  attr_reader :short, :long, :arg, :description, :block
Severity: Minor
Found in mspec/lib/mspec/utils/options.rb - About 5 hrs to fix

    Method parse has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
    Open

      def parse(argv=ARGV)
    argv = Array(argv).dup

    while entry = argv.shift
      # collect everything that is not an option
    Severity: Minor
    Found in mspec/lib/mspec/utils/options.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class MSpecOptions has 30 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class MSpecOptions
  # Raised if incorrect or incomplete formats are passed to #on.
  class OptionError < Exception; end

  # Raised if an unrecognized option is encountered.
    Severity: Minor
    Found in mspec/lib/mspec/utils/options.rb - About 3 hrs to fix

      Method targets has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def targets
    on("-t", "--target", "TARGET",
       "Implementation to run the specs, where TARGET is:") do |t|
      case t
      when 'r', 'ruby'
      Severity: Minor
      Found in mspec/lib/mspec/utils/options.rb - About 2 hrs to fix

        Method formatters has 49 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def formatters
    on("-f", "--format", "FORMAT",
       "Formatter for reporting, where FORMAT is one of:") do |o|
      case o
      when 's', 'spec', 'specdoc'
        Severity: Minor
        Found in mspec/lib/mspec/utils/options.rb - About 1 hr to fix

          Method process has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

            def process(argv, entry, opt, arg)
    unless option = match?(opt)
      @on_extra[entry]
    else
      if option.arg?
          Severity: Minor
          Found in mspec/lib/mspec/utils/options.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method filters has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def filters
    on("-e", "--example", "STR",
       "Run examples with descriptions matching STR") do |o|
      config[:includes] << o
    end
          Severity: Minor
          Found in mspec/lib/mspec/utils/options.rb - About 1 hr to fix

            Method parse has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def parse(argv=ARGV)
    argv = Array(argv).dup

    while entry = argv.shift
      # collect everything that is not an option
            Severity: Minor
            Found in mspec/lib/mspec/utils/options.rb - About 1 hr to fix

              Method on has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def on(*args, &block)
    raise OptionError, "option and description are required" if args.size < 2

    description = args.pop
    short, long, argument = nil
              Severity: Minor
              Found in mspec/lib/mspec/utils/options.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method add has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                def add(short, long, arg, description, block)
              Severity: Minor
              Found in mspec/lib/mspec/utils/options.rb - About 35 mins to fix

                Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  def initialize(short, long, arg, description, block)
                Severity: Minor
                Found in mspec/lib/mspec/utils/options.rb - About 35 mins to fix

                  Method add has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def add(short, long, arg, description, block)
    s = short ? short.dup : "  "
    s += (short ? ", " : "  ") if long
    doc "   #{s}#{long} #{arg}".ljust(@width-1) + " #{description}"
    @options << MSpecOption.new(short, long, arg, description, block)
                  Severity: Minor
                  Found in mspec/lib/mspec/utils/options.rb - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                    def on(*args, &block)
    raise OptionError, "option and description are required" if args.size < 2

    description = args.pop
    short, long, argument = nil
                  Severity: Major
                  Found in mspec/lib/mspec/utils/options.rb and 1 other location - About 1 hr to fix
                  core/options.rb on lines 105..122

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 48.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                        while rest.size > 0
        opt, arg, rest = split rest, 1
        opt = "-" + opt
        option = process argv, opt, opt, arg
        break if option.arg?
                  Severity: Minor
                  Found in mspec/lib/mspec/utils/options.rb and 1 other location - About 25 mins to fix
                  core/options.rb on lines 203..207

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 29.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status