lib/rubocop/cop/internal_affairs/offense_location_keyword.rb
# frozen_string_literal: true
module RuboCop
module Cop
module InternalAffairs
# Checks for potential uses of the location keywords which can be used as
# shortcut arguments to `#add_offense`.
#
# @example
#
# # bad
# add_offense(node, location: node.loc.selector)
#
# # good
# add_offense(node, location: :selector)
class OffenseLocationKeyword < Base
extend AutoCorrector
MSG = 'Use `:%<keyword>s` as the location argument to `#add_offense`.'
RESTRICT_ON_SEND = %i[add_offense].freeze
def on_send(node)
node_type_check(node) do |node_arg, kwargs|
find_offending_argument(node_arg, kwargs) do |location, keyword|
add_offense(location, message: format(MSG, keyword: keyword)) do |corrector|
(*, keyword) = offending_location_argument(location.parent)
corrector.replace(location, ":#{keyword}")
end
end
end
end
private
# @!method node_type_check(node)
def_node_matcher :node_type_check, <<~PATTERN
(send nil? :add_offense $_node $hash)
PATTERN
# @!method offending_location_argument(node)
def_node_matcher :offending_location_argument, <<~PATTERN
(pair (sym :location) $(send (send $_node :loc) $_keyword))
PATTERN
def find_offending_argument(searched_node, kwargs)
kwargs.pairs.each do |pair|
offending_location_argument(pair) do |location, node, keyword|
yield(location, keyword) if searched_node == node
end
end
end
end
end
end
end