rubocop-hq/rubocop

View on GitHub
lib/rubocop/cop/style/method_call_without_args_parentheses.rb

Summary

Maintainability
A
2 hrs
Test Coverage
A
100%

Method on_send has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

        def on_send(node)
          return unless !node.arguments? && node.parenthesized?
          return if ineligible_node?(node)
          return if default_argument?(node)
          return if allowed_method_name?(node.method_name)
Severity: Minor
Found in lib/rubocop/cop/style/method_call_without_args_parentheses.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parenthesized_it_method_in_block? has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

        def parenthesized_it_method_in_block?(node)
          return false unless node.method?(:it)
          return false unless (block_node = node.each_ancestor(:block).first)
          return false unless block_node.arguments.empty_and_without_delimiters?

Severity: Minor
Found in lib/rubocop/cop/style/method_call_without_args_parentheses.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

          return if same_name_assignment?(node)
Severity: Major
Found in lib/rubocop/cop/style/method_call_without_args_parentheses.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

              return if parenthesized_it_method_in_block?(node)
    Severity: Major
    Found in lib/rubocop/cop/style/method_call_without_args_parentheses.rb - About 30 mins to fix

      Method any_assignment? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

              def any_assignment?(node)
                node.each_ancestor(*AST::Node::ASSIGNMENTS).any? do |asgn_node|
                  # `obj.method = value` parses as (send ... :method= ...), and will
                  # not be returned as an `asgn_node` here, however,
                  # `obj.method ||= value` parses as (or-asgn (send ...) ...)
      Severity: Minor
      Found in lib/rubocop/cop/style/method_call_without_args_parentheses.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status