Sign upLogin

rubocop-hq/rubocop

View on GitHub
Star
lib/rubocop/cop/style/min_max_comparison.rb

Summary

Maintainability
A
1 hr
Test Coverage
A
100%

Method preferred_method has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

        def preferred_method(operator, lhs, rhs, if_branch, else_branch)
          if lhs == if_branch && rhs == else_branch
            GRATER_OPERATORS.include?(operator) ? 'max' : 'min'
          elsif lhs == else_branch && rhs == if_branch
            LESS_OPERATORS.include?(operator) ? 'max' : 'min'
Severity: Minor
Found in lib/rubocop/cop/style/min_max_comparison.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method preferred_method has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        def preferred_method(operator, lhs, rhs, if_branch, else_branch)
Severity: Minor
Found in lib/rubocop/cop/style/min_max_comparison.rb - About 35 mins to fix

    There are no issues that match your filters.

    Category
    Status