Sign upLogin

ruboto/ruboto

View on GitHub
Star
assets/app/src/main/java/org/jruby/util/JavaNameMangler.java

Summary

Maintainability
D
2 days
Test Coverage

Method mangleFilenameForClasspath has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public static String mangleFilenameForClasspath(String filename, String parent, String prefix, boolean canonicalize,
                                                    boolean preserveIdentifiers) {
        String classPath; final int idx = filename.indexOf('!');
        if (idx != -1) {
            String before = filename.substring(6, idx);
Severity: Minor
Found in assets/app/src/main/java/org/jruby/util/JavaNameMangler.java - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File JavaNameMangler.java has 284 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/***** BEGIN LICENSE BLOCK *****
 * Version: EPL 2.0/GPL 2.0/LGPL 2.1
 *
 * The contents of this file are subject to the Eclipse Public
 * License Version 2.0 (the "License"); you may not use this file
Severity: Minor
Found in assets/app/src/main/java/org/jruby/util/JavaNameMangler.java - About 2 hrs to fix

    Method mangleFilenameForClasspath has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static String mangleFilenameForClasspath(String filename, String parent, String prefix, boolean canonicalize,
                                                    boolean preserveIdentifiers) {
        String classPath; final int idx = filename.indexOf('!');
        if (idx != -1) {
            String before = filename.substring(6, idx);
    Severity: Major
    Found in assets/app/src/main/java/org/jruby/util/JavaNameMangler.java - About 2 hrs to fix

      Method mangleStringForCleanJavaIdentifier has 64 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private static void mangleStringForCleanJavaIdentifier(final StringBuilder buffer,
                                                           final String name) {
        final char[] chars = name.toCharArray();
        final int len = chars.length;
        buffer.ensureCapacity(buffer.length() + len * 2);
      Severity: Major
      Found in assets/app/src/main/java/org/jruby/util/JavaNameMangler.java - About 2 hrs to fix

        Method mangleStringForCleanJavaIdentifier has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            private static void mangleStringForCleanJavaIdentifier(final StringBuilder buffer,
                                                           final String name) {
        final char[] chars = name.toCharArray();
        final int len = chars.length;
        buffer.ensureCapacity(buffer.length() + len * 2);
        Severity: Minor
        Found in assets/app/src/main/java/org/jruby/util/JavaNameMangler.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method encodeScopeForBacktrace has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static String encodeScopeForBacktrace(IRScope scope) {
        if (scope instanceof IRMethod) {
            return "RUBY$method$" + mangleMethodNameInternal(scope.getId());
        }
        if (scope instanceof IRClosure) {
        Severity: Minor
        Found in assets/app/src/main/java/org/jruby/util/JavaNameMangler.java - About 1 hr to fix

          Method encodeScopeForBacktrace has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public static String encodeScopeForBacktrace(IRScope scope) {
        if (scope instanceof IRMethod) {
            return "RUBY$method$" + mangleMethodNameInternal(scope.getId());
        }
        if (scope instanceof IRClosure) {
          Severity: Minor
          Found in assets/app/src/main/java/org/jruby/util/JavaNameMangler.java - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method mangleMethodNameInternal has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              private static CharSequence mangleMethodNameInternal(final String name) {
        // scan for characters that need escaping
        StringBuilder builder = null; // lazy
        for (int i = 0; i < name.length(); i++) {
            char candidate = name.charAt(i);
          Severity: Minor
          Found in assets/app/src/main/java/org/jruby/util/JavaNameMangler.java - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method mangleFilenameForClasspath has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public static String mangleFilenameForClasspath(String filename, String parent, String prefix, boolean canonicalize,
                                                    boolean preserveIdentifiers) {
          Severity: Minor
          Found in assets/app/src/main/java/org/jruby/util/JavaNameMangler.java - About 35 mins to fix

            Method willMethodMangleOk has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                @Deprecated
    public static boolean willMethodMangleOk(CharSequence name) {
        if (false && Platform.IS_IBM) {
            // IBM's JVM is much less forgiving, so we disallow anything with non-alphanumeric, _, and $
            for ( int i = 0; i < name.length(); i++ ) {
            Severity: Minor
            Found in assets/app/src/main/java/org/jruby/util/JavaNameMangler.java - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this method.
            Open

                        return "RUBY$script";
            Severity: Major
            Found in assets/app/src/main/java/org/jruby/util/JavaNameMangler.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return "RUBY$module$" + mangleMethodNameInternal(scope.getId());
              Severity: Major
              Found in assets/app/src/main/java/org/jruby/util/JavaNameMangler.java - About 30 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            try {
                if (canonicalize) {
                    classPath = new JRubyFile(filename).getCanonicalPath();
                } else {
                    classPath = new JRubyFile(filename).toString();
                Severity: Minor
                Found in assets/app/src/main/java/org/jruby/util/JavaNameMangler.java and 1 other location - About 40 mins to fix
                assets/app/src/main/java/org/jruby/util/JavaNameMangler.java on lines 96..105

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                            try {
                if (canonicalize) {
                    parentPath = new JRubyFile(parent).getCanonicalPath();
                } else {
                    parentPath = new JRubyFile(parent).toString();
                Severity: Minor
                Found in assets/app/src/main/java/org/jruby/util/JavaNameMangler.java and 1 other location - About 40 mins to fix
                assets/app/src/main/java/org/jruby/util/JavaNameMangler.java on lines 82..91

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 48.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status