Method toOpenOptions
has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
public OpenOption[] toOpenOptions(boolean includeAppend, boolean includeTruncate) {
int size = 0;
// standard
boolean writable = false;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File ModeFlags.java
has 294 lines of code (exceeds 250 allowed). Consider refactoring. Open
/*
***** BEGIN LICENSE BLOCK *****
* Version: EPL 2.0/GPL 2.0/LGPL 2.1
*
* The contents of this file are subject to the Eclipse Public
ModeFlags
has 26 methods (exceeds 20 allowed). Consider refactoring. Open
public class ModeFlags implements Cloneable {
/** read-only flag (default value if no other flags set) */
public static final int RDONLY = OpenFlags.O_RDONLY.intValue();
/** write-only flag */
public static final int WRONLY = OpenFlags.O_WRONLY.intValue();
Method toString
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
@Override
public String toString() {
StringBuilder buf = new StringBuilder();
buf.append("ModeFlags(").append(flags).append("): ");
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getOFlagsFromString
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static int getOFlagsFromString(String modesString) throws InvalidValueException {
int modes = 0;
int length = modesString.length();
if (length == 0) {
Method oflagsFrom
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
public static int oflagsFrom(POSIX posix, Channel channel) {
int mode;
int fileno = FilenoUtil.filenoFrom(channel);
if (FilenoUtil.isFake(fileno) || !posix.isNative() || Platform.IS_WINDOWS) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getOpenFileFlagsFor
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static int getOpenFileFlagsFor(int flags) {
int fmodeFlags;
int readWrite = flags & 3;
if (readWrite == RDONLY) {
Method toOpenOptions
has 26 lines of code (exceeds 25 allowed). Consider refactoring. Open
public OpenOption[] toOpenOptions(boolean includeAppend, boolean includeTruncate) {
int size = 0;
// standard
boolean writable = false;
Method getOpenFileFlagsFor
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public static int getOpenFileFlagsFor(int flags) {
int fmodeFlags;
int readWrite = flags & 3;
if (readWrite == RDONLY) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method getOFlagsFromString
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
public static int getOFlagsFromString(String modesString) throws InvalidValueException {
int modes = 0;
int length = modesString.length();
if (length == 0) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Consider simplifying this complex logical expression. Open
if ((!superset.isReadable() && isReadable()) ||
(!superset.isWritable() && isWritable()) ||
!superset.isAppendable() && isAppendable()) {
return false;
Method getModesFromChannel
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
@Deprecated
public static ModeFlags getModesFromChannel(Channel channel) {
try {
ModeFlags modes;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
switch (modesString.charAt(0)) {
case 'r' :
modes |= RDONLY;
break;
case 'a' :
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 72.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76