Sign upLogin

ruboto/ruboto

View on GitHub
Star
assets/app/src/main/java/org/ruboto/ScriptLoader.java

Summary

Maintainability
C
1 day
Test Coverage

Method loadScript has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
Open

    public static void loadScript(final RubotoComponent component) {
        try {
            if (component.getScriptInfo().getScriptName() != null) {
                Log.d("Looking for Ruby class: " + component.getScriptInfo().getRubyClassName());
                Object rubyClass = JRubyAdapter.get(component.getScriptInfo().getRubyClassName());
Severity: Minor
Found in assets/app/src/main/java/org/ruboto/ScriptLoader.java - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadScript has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static void loadScript(final RubotoComponent component) {
        try {
            if (component.getScriptInfo().getScriptName() != null) {
                Log.d("Looking for Ruby class: " + component.getScriptInfo().getRubyClassName());
                Object rubyClass = JRubyAdapter.get(component.getScriptInfo().getRubyClassName());
Severity: Major
Found in assets/app/src/main/java/org/ruboto/ScriptLoader.java - About 3 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                                if (rubyClass == null && hasBackingJavaClass) {
                                Log.d("Script has separate Java class");
                                rubyClass = JRubyAdapter.runScriptlet("Java::" + component.getClass().getName());
                            }
    Severity: Major
    Found in assets/app/src/main/java/org/ruboto/ScriptLoader.java - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                                  if (rubyClass != null && !rubyClass.toString().startsWith("Java::")) {
                                Log.d("Found Ruby class instead of Java class.  Reloading.");
                                rubyClass = null;
                            }
      Severity: Major
      Found in assets/app/src/main/java/org/ruboto/ScriptLoader.java - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status