ruby-concurrency/concurrent-ruby

View on GitHub
lib/concurrent-ruby-edge/concurrent/edge/throttle.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method acquire has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def acquire(timeout = nil, &block)
      event = acquire_or_event
      if event
        within_timeout = event.wait(timeout)
        # release immediately when acquired later after the timeout since it is unused
Severity: Minor
Found in lib/concurrent-ruby-edge/concurrent/edge/throttle.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method acquire has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def acquire(timeout = nil, &block)
      event = acquire_or_event
      if event
        within_timeout = event.wait(timeout)
        # release immediately when acquired later after the timeout since it is unused
Severity: Minor
Found in lib/concurrent-ruby-edge/concurrent/edge/throttle.rb - About 1 hr to fix

    Method release has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def release
          while true
            current_capacity = capacity
            if compare_and_set_capacity current_capacity, current_capacity + 1
              if current_capacity < 0
    Severity: Minor
    Found in lib/concurrent-ruby-edge/concurrent/edge/throttle.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method try_acquire has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def try_acquire
          while true
            current_capacity = capacity
            if current_capacity > 0
              return true if compare_and_set_capacity(
    Severity: Minor
    Found in lib/concurrent-ruby-edge/concurrent/edge/throttle.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method acquire_or_event has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def acquire_or_event
          while true
            current_capacity = capacity
            if compare_and_set_capacity current_capacity, current_capacity - 1
              if current_capacity > 0
    Severity: Minor
    Found in lib/concurrent-ruby-edge/concurrent/edge/throttle.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status