Sign upLogin

rubycas/rubycas-client

View on GitHub
Star
lib/casclient/frameworks/rails/cas_proxy_callback_controller.rb

Summary

Maintainability
A
25 mins
Test Coverage

Method receive_pgt has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def receive_pgt
    #FIXME: these checks don't work because REMOTE_HOST doesn't work consistently under all web servers (for example it doesn't work at all under mongrel)
    #                ... need to find a reliable way to check if the request came through from a reverse HTTPS proxy -- until then I'm disabling this check
    #render_error "PGTs can be received only via HTTPS or local connections." and return unless
    #  request.ssl? or request.env['REMOTE_HOST'] == "127.0.0.1"
Severity: Minor
Found in lib/casclient/frameworks/rails/cas_proxy_callback_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status