rubycentral/cfp-app

View on GitHub
app/models/event.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Class Event has 36 methods (exceeds 20 allowed). Consider refactoring.
Open

class Event < ApplicationRecord
  has_many :teammates, dependent: :destroy
  has_many :staff, through: :teammates, source: :user
  has_many :proposals, dependent: :destroy
  has_many :speakers
Severity: Minor
Found in app/models/event.rb - About 4 hrs to fix

    Method incomplete_checklist_items has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def incomplete_checklist_items
        missing_items = []
    
        missing_items << "Event must have a url" unless url.present?
        missing_items << "Event must have a start date" unless start_date
    Severity: Minor
    Found in app/models/event.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method unmet_requirements_for_scheduling has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def unmet_requirements_for_scheduling
        missing_prereqs = []
    
        missing_prereqs << "Event must have a start date" unless start_date
        missing_prereqs << "Event must have a end date" unless end_date
    Severity: Minor
    Found in app/models/event.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status