Sign upLogin

rubyjedi/soap4r

View on GitHub
Star
lib/soap/encodingstyle/soapHandler.rb

Summary

Maintainability
F
4 days
Test Coverage

File soapHandler.rb has 476 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'soap/encodingstyle/handler'
require 'soap/mapping/registry'


module SOAP
Severity: Minor
Found in lib/soap/encodingstyle/soapHandler.rb - About 7 hrs to fix

    Method encode_attrs has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
    Open

      def encode_attrs(generator, ns, data, parent)
    attrs = {}
    return attrs if data.is_a?(SOAPReference)

    if !parent || parent.encodingstyle != EncodingNamespace
    Severity: Minor
    Found in lib/soap/encodingstyle/soapHandler.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Class SOAPHandler has 25 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class SOAPHandler < Handler
  Namespace = SOAP::EncodingNamespace
  add_handler

  def initialize(charset = nil)
    Severity: Minor
    Found in lib/soap/encodingstyle/soapHandler.rb - About 2 hrs to fix

      Method decode_tag_by_wsdl has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
      Open

        def decode_tag_by_wsdl(ns, elename, typestr, parent, arytypestr, attrs)
    o = nil
    if parent.class == SOAPBody
      # root element: should branch by root attribute?
      if @is_first_top_ele
      Severity: Minor
      Found in lib/soap/encodingstyle/soapHandler.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method encode_attrs has 46 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def encode_attrs(generator, ns, data, parent)
    attrs = {}
    return attrs if data.is_a?(SOAPReference)

    if !parent || parent.encodingstyle != EncodingNamespace
      Severity: Minor
      Found in lib/soap/encodingstyle/soapHandler.rb - About 1 hr to fix

        Method decode_tag_by_wsdl has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def decode_tag_by_wsdl(ns, elename, typestr, parent, arytypestr, attrs)
    o = nil
    if parent.class == SOAPBody
      # root element: should branch by root attribute?
      if @is_first_top_ele
        Severity: Minor
        Found in lib/soap/encodingstyle/soapHandler.rb - About 1 hr to fix

          Method encode_data has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def encode_data(generator, ns, data, parent)
    attrs = encode_attrs(generator, ns, data, parent)
    if parent && parent.is_a?(SOAPArray) && parent.position
      attrs[ns.name(AttrPositionName)] = "[#{parent.position.join(',')}]"
    end
          Severity: Minor
          Found in lib/soap/encodingstyle/soapHandler.rb - About 1 hr to fix

            Method decode_tag has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

              def decode_tag(ns, elename, attrs, parent)
    @textbuf.clear
    is_nil, type, arytype, root, offset, position, href, id =
      extract_attrs(ns, attrs)
    o = nil
            Severity: Minor
            Found in lib/soap/encodingstyle/soapHandler.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method decode_tag has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def decode_tag(ns, elename, attrs, parent)
    @textbuf.clear
    is_nil, type, arytype, root, offset, position, href, id =
      extract_attrs(ns, attrs)
    o = nil
            Severity: Minor
            Found in lib/soap/encodingstyle/soapHandler.rb - About 1 hr to fix

              Method encode_data has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                def encode_data(generator, ns, data, parent)
    attrs = encode_attrs(generator, ns, data, parent)
    if parent && parent.is_a?(SOAPArray) && parent.position
      attrs[ns.name(AttrPositionName)] = "[#{parent.position.join(',')}]"
    end
              Severity: Minor
              Found in lib/soap/encodingstyle/soapHandler.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method decode_defined_complextype has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def decode_defined_complextype(elename, typename, typedef, arytypestr)
    case typedef.compoundtype
    when :TYPE_STRUCT, :TYPE_MAP
      o = SOAPStruct.decode(elename, typename)
      o.definedtype = typedef
              Severity: Minor
              Found in lib/soap/encodingstyle/soapHandler.rb - About 1 hr to fix

                Method decode_parent has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                  def decode_parent(parent, node)
    return unless parent.node
    case parent.node
    when SOAPUnknown
      newparent = parent.node.as_struct
                Severity: Minor
                Found in lib/soap/encodingstyle/soapHandler.rb - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method decode_tag_by_wsdl has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                  def decode_tag_by_wsdl(ns, elename, typestr, parent, arytypestr, attrs)
                Severity: Minor
                Found in lib/soap/encodingstyle/soapHandler.rb - About 45 mins to fix

                  Method decode_tag_by_type has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                    def decode_tag_by_type(ns, elename, typestr, parent, arytypestr, attrs)
                  Severity: Minor
                  Found in lib/soap/encodingstyle/soapHandler.rb - About 45 mins to fix

                    Method decode_tag_by_type has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def decode_tag_by_type(ns, elename, typestr, parent, arytypestr, attrs)
    if arytypestr
      type = typestr ? ns.parse(typestr) : ValueArrayName
      node = SOAPArray.decode(elename, type, ns.parse(arytypestr))
      node.extraattr.update(attrs)
                    Severity: Minor
                    Found in lib/soap/encodingstyle/soapHandler.rb - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method decode_resolve_id has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                      def decode_resolve_id
    count = @refpool.length    # To avoid infinite loop
    while !@refpool.empty? && count > 0
      @refpool = @refpool.find_all { |ref|
    o = @idpool.find { |item|
                    Severity: Minor
                    Found in lib/soap/encodingstyle/soapHandler.rb - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid too many return statements within this method.
                    Open

                          return decode_basetype(klass, elename)
                    Severity: Major
                    Found in lib/soap/encodingstyle/soapHandler.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                            return decode_tag_by_type(ns, elename, typestr, parent, arytypestr, attrs)
                      Severity: Major
                      Found in lib/soap/encodingstyle/soapHandler.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                              return decode_tag_by_type(ns, elename, typestr, parent, arytypestr, attrs)
                        Severity: Major
                        Found in lib/soap/encodingstyle/soapHandler.rb - About 30 mins to fix

                          Method decode_tag_end has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                          Open

                            def decode_tag_end(ns, node)
    textbufstr = @textbuf.join
    @textbuf.clear
    o = node.node
    if o.is_a?(SOAPUnknown)
                          Severity: Minor
                          Found in lib/soap/encodingstyle/soapHandler.rb - About 25 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                              when SOAPArray
      if node.position
    parent.node[*(decode_arypos(node.position))] = node
    parent.node.sparse = true
      else
                          Severity: Minor
                          Found in lib/soap/encodingstyle/soapHandler.rb and 1 other location - About 20 mins to fix
                          lib/soap/encodingstyle/literalHandler.rb on lines 159..166

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 27.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status