Sign upLogin

rubyjedi/soap4r

View on GitHub
Star
lib/soap/mapping/wsdlliteralregistry.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method complexobj2soapchildren_array has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def complexobj2soapchildren_array(obj, soap, child_ele, nillable)
    child = Mapping.get_attribute(obj, child_ele.name.name)
    if child.nil? and obj.is_a?(::Array)
      child = obj
    end
Severity: Minor
Found in lib/soap/mapping/wsdlliteralregistry.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method complexobj2sequencesoap has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def complexobj2sequencesoap(obj, soap, type, nillable, is_choice)
    added = false
    type.elements.each do |child_ele|
      case child_ele
      when WSDL::XMLSchema::Any
Severity: Minor
Found in lib/soap/mapping/wsdlliteralregistry.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method obj2elesoap has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

  def obj2elesoap(obj, eledef)
    ele = nil
    qualified = (eledef.elementform == 'qualified')
    if obj.is_a?(SOAPNil)
      ele = obj
Severity: Minor
Found in lib/soap/mapping/wsdlliteralregistry.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method obj2typesoap has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def obj2typesoap(obj, type)
    ele = nil
    if type.is_a?(::WSDL::XMLSchema::SimpleType)
      ele = simpleobj2soap(obj, type)
    else # complexType
Severity: Minor
Found in lib/soap/mapping/wsdlliteralregistry.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method obj2soap has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def obj2soap(obj, qname, obj_class = nil)
    soap_obj = nil
    if obj.is_a?(SOAPElement)
      soap_obj = obj
    elsif eledef = @definedelements[qname]
Severity: Minor
Found in lib/soap/mapping/wsdlliteralregistry.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method complexobj2sequencesoap has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def complexobj2sequencesoap(obj, soap, type, nillable, is_choice)
Severity: Minor
Found in lib/soap/mapping/wsdlliteralregistry.rb - About 35 mins to fix

    Method simpleobj2soap has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def simpleobj2soap(obj, type)
    type.check_lexical_format(obj)
    return SOAPNil.new if obj.nil?
    if type.base
      ele = base2soap(obj, TypeMap[type.base])
    Severity: Minor
    Found in lib/soap/mapping/wsdlliteralregistry.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method complexobj2soapchildren_single has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def complexobj2soapchildren_single(obj, soap, child_ele, nillable)
    child = Mapping.get_attribute(obj, child_ele.name.name)
    case child
    when NilClass
      return false if nillable
    Severity: Minor
    Found in lib/soap/mapping/wsdlliteralregistry.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method soap2obj has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def soap2obj(node, obj_class = nil)
    cause = nil
    begin
      return any2obj(node, obj_class)
    rescue MappingError
    Severity: Minor
    Found in lib/soap/mapping/wsdlliteralregistry.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        elsif type.list
      value = obj.is_a?(Array) ? obj.join(" ") : obj.to_s
      ele = base2soap(value, SOAP::SOAPString)
    else
      raise MappingError.new("unsupported simpleType: #{type}")
    Severity: Minor
    Found in lib/soap/mapping/wsdlliteralregistry.rb and 1 other location - About 15 mins to fix
    lib/soap/mapping/wsdlencodedregistry.rb on lines 132..136

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status