rubyjedi/soap4r

View on GitHub
lib/soap/rpc/proxy.rb

Summary

Maintainability
F
3 days
Test Coverage

File proxy.rb has 499 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'soap/soap'
require 'soap/processor'
require 'soap/mapping'
require 'soap/mapping/literalregistry'
require 'soap/rpc/rpc'
Severity: Minor
Found in lib/soap/rpc/proxy.rb - About 1 day to fix

    Class Proxy has 24 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Proxy
      include SOAP
    
    public
    
    
    Severity: Minor
    Found in lib/soap/rpc/proxy.rb - About 2 hrs to fix

      Class Operation has 21 methods (exceeds 20 allowed). Consider refactoring.
      Open

        class Operation
          attr_reader :soapaction
          attr_reader :request_style
          attr_reader :response_style
          attr_reader :request_use
      Severity: Minor
      Found in lib/soap/rpc/proxy.rb - About 2 hrs to fix

        Method call has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def call(name, *params)
            # name must be used only for lookup
            op_info = lookup_operation(name)
            mapping_opt = create_mapping_opt
            req_header = create_request_header
        Severity: Minor
        Found in lib/soap/rpc/proxy.rb - About 1 hr to fix

          Method unmarshal has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

            def unmarshal(conn_data, opt)
              contenttype = conn_data.receive_contenttype
              xml = nil
              if /#{MIMEMessage::MultipartContentType}/i =~ contenttype
                opt[:external_content] = {}
          Severity: Minor
          Found in lib/soap/rpc/proxy.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method initialize has 37 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def initialize(soapaction, param_def, opt)
                @soapaction = soapaction
                @request_style = opt[:request_style]
                @response_style = opt[:response_style]
                @request_use = opt[:request_use]
          Severity: Minor
          Found in lib/soap/rpc/proxy.rb - About 1 hr to fix

            Method unmarshal has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def unmarshal(conn_data, opt)
                contenttype = conn_data.receive_contenttype
                xml = nil
                if /#{MIMEMessage::MultipartContentType}/i =~ contenttype
                  opt[:external_content] = {}
            Severity: Minor
            Found in lib/soap/rpc/proxy.rb - About 1 hr to fix

              Method call has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                def call(name, *params)
                  # name must be used only for lookup
                  op_info = lookup_operation(name)
                  mapping_opt = create_mapping_opt
                  req_header = create_request_header
              Severity: Minor
              Found in lib/soap/rpc/proxy.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method initialize has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                  def initialize(soapaction, param_def, opt)
                    @soapaction = soapaction
                    @request_style = opt[:request_style]
                    @response_style = opt[:response_style]
                    @request_use = opt[:request_use]
              Severity: Minor
              Found in lib/soap/rpc/proxy.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method add_rpc_operation has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                def add_rpc_operation(qname, soapaction, name, param_def, opt = {})
              Severity: Minor
              Found in lib/soap/rpc/proxy.rb - About 35 mins to fix

                Method initialize_streamhandler has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  def initialize_streamhandler(options)
                    value = options["streamhandler"]
                    if value and !value.empty?
                      factory = Property::Util.const_from_name(value)
                    else
                Severity: Minor
                Found in lib/soap/rpc/proxy.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method ensure_styleuse_option has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                  def ensure_styleuse_option(opt, style, use)
                    if opt[:request_style] || opt[:response_style] || opt[:request_use] || opt[:response_use]
                      # do not edit
                    else
                      opt[:request_style] ||= style
                Severity: Minor
                Found in lib/soap/rpc/proxy.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method assign_operation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                  def assign_operation(name, qname, soapaction, op)
                    assigned = false
                    if name and !name.empty?
                      @operation[name] = op
                      assigned = true
                Severity: Minor
                Found in lib/soap/rpc/proxy.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        @doc_request_qnames = []
                        @doc_response_qnames = []
                        param_def.each do |param|
                          param = MethodDef.to_param(param)
                          case param.io_type
                Severity: Minor
                Found in lib/soap/rpc/proxy.rb and 1 other location - About 45 mins to fix
                lib/soap/rpc/router.rb on lines 426..437

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 40.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                  def ensure_styleuse_option(opt, style, use)
                    if opt[:request_style] || opt[:response_style] || opt[:request_use] || opt[:response_use]
                      # do not edit
                    else
                      opt[:request_style] ||= style
                Severity: Minor
                Found in lib/soap/rpc/proxy.rb and 1 other location - About 45 mins to fix
                lib/soap/rpc/router.rb on lines 237..245

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 39.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                      mime.parts.each do |part|
                    value = Attachment.new(part.content)
                    value.contentid = part.contentid
                    obj = SOAPAttachment.new(value)
                    opt[:external_content][value.contentid] = obj if value.contentid
                Severity: Minor
                Found in lib/soap/rpc/proxy.rb and 1 other location - About 25 mins to fix
                lib/soap/rpc/router.rb on lines 300..304

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 29.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    def request_doc_enc(values, mapping_registry, opt)
                      (0...values.size).collect { |idx|
                        ele = Mapping.obj2soap(values[idx], mapping_registry, nil, opt)
                        ele.elename = @doc_request_qnames[idx]
                        ele
                Severity: Minor
                Found in lib/soap/rpc/proxy.rb and 1 other location - About 15 mins to fix
                lib/soap/rpc/router.rb on lines 600..604

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 25.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status