rubyjedi/soap4r

View on GitHub
lib/wsdl/definitions.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Class Definitions has 23 methods (exceeds 20 allowed). Consider refactoring.
Open

class Definitions < Info
  attr_reader :name
  attr_reader :targetnamespace
  attr_reader :imports

Severity: Minor
Found in lib/wsdl/definitions.rb - About 2 hrs to fix

    Method parse_element has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def parse_element(element)
        case element
        when ImportName
          o = Import.new
          @imports << o
    Severity: Minor
    Found in lib/wsdl/definitions.rb - About 1 hr to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        def service(name)
          service = @services[name]
          return service if service
          @imports.each do |import|
            service = import.content.service(name) if self.class === import.content
      Severity: Minor
      Found in lib/wsdl/definitions.rb and 3 other locations - About 25 mins to fix
      lib/wsdl/definitions.rb on lines 116..123
      lib/wsdl/definitions.rb on lines 126..133
      lib/wsdl/definitions.rb on lines 136..143

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        def porttype(name)
          porttype = @porttypes[name]
          return porttype if porttype
          @imports.each do |import|
            porttype = import.content.porttype(name) if self.class === import.content
      Severity: Minor
      Found in lib/wsdl/definitions.rb and 3 other locations - About 25 mins to fix
      lib/wsdl/definitions.rb on lines 116..123
      lib/wsdl/definitions.rb on lines 136..143
      lib/wsdl/definitions.rb on lines 146..153

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        def binding(name)
          binding = @bindings[name]
          return binding if binding
          @imports.each do |import|
            binding = import.content.binding(name) if self.class === import.content
      Severity: Minor
      Found in lib/wsdl/definitions.rb and 3 other locations - About 25 mins to fix
      lib/wsdl/definitions.rb on lines 116..123
      lib/wsdl/definitions.rb on lines 126..133
      lib/wsdl/definitions.rb on lines 146..153

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

        def message(name)
          message = @messages[name]
          return message if message
          @imports.each do |import|
            message = import.content.message(name) if self.class === import.content
      Severity: Minor
      Found in lib/wsdl/definitions.rb and 3 other locations - About 25 mins to fix
      lib/wsdl/definitions.rb on lines 126..133
      lib/wsdl/definitions.rb on lines 136..143
      lib/wsdl/definitions.rb on lines 146..153

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 31.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status