Sign upLogin

rubyjedi/soap4r

View on GitHub
Star
lib/wsdl/soap/methodDefCreator.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method rpcdefinedtype has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def rpcdefinedtype(part)
    if mapped = basetype_mapped_class(part.type)
      return ['::' + mapped.name, nil]
    elsif definedtype = @simpletypes[part.type]
      return [nil, definedtype.name]
Severity: Minor
Found in lib/wsdl/soap/methodDefCreator.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method documentdefinedtype has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def documentdefinedtype(part)
    if mapped = basetype_mapped_class(part.type)
      return ['::' + mapped.name, XSD::QName.new(nil, part.name)]
    elsif definedtype = @simpletypes[part.type]
      if definedtype.base
Severity: Minor
Found in lib/wsdl/soap/methodDefCreator.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return [nil, nil]
Severity: Major
Found in lib/wsdl/soap/methodDefCreator.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

        return [Hash.name, part.type]
    Severity: Major
    Found in lib/wsdl/soap/methodDefCreator.rb - About 30 mins to fix

      Method create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def create(bindingname)
    binding = @definitions.binding(bindingname)
    if binding
      return binding.operations.collect { |op_bind|
        next unless op_bind.soapoperation # not a SOAP operation binding
      Severity: Minor
      Found in lib/wsdl/soap/methodDefCreator.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status