Sign upLogin

rueian/rueidis

View on GitHub
Star
cluster.go

Summary

Maintainability
F
1 wk
Test Coverage
A
100%

File cluster.go has 1199 lines of code (exceeds 500 allowed). Consider refactoring.
Open

package rueidis

import (
    "context"
    "errors"
Severity: Major
Found in cluster.go - About 2 days to fix

    Method clusterClient._refresh has a Cognitive Complexity of 77 (exceeds 20 allowed). Consider refactoring.
    Open

    func (c *clusterClient) _refresh() (err error) {
    c.mu.RLock()
    results := make(chan clusterslots, len(c.conns))
    pending := make([]conn, 0, len(c.conns))
    if c.aws {
    Severity: Minor
    Found in cluster.go - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    clusterClient has 34 methods (exceeds 20 allowed). Consider refactoring.
    Open

    type clusterClient struct {
    pslots [16384]conn
    rslots []conn
    opt    *ClientOption
    rOpt   *ClientOption
    Severity: Minor
    Found in cluster.go - About 4 hrs to fix

      Method clusterClient._refresh has 115 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (c *clusterClient) _refresh() (err error) {
    c.mu.RLock()
    results := make(chan clusterslots, len(c.conns))
    pending := make([]conn, 0, len(c.conns))
    if c.aws {
      Severity: Major
      Found in cluster.go - About 3 hrs to fix

        Method clusterClient._pickMulti has a Cognitive Complexity of 36 (exceeds 20 allowed). Consider refactoring.
        Open

        func (c *clusterClient) _pickMulti(multi []Completed) (retries *connretry, last uint16, toReplica bool) {
    last = cmds.InitSlot
    init := false

    for _, cmd := range multi {
        Severity: Minor
        Found in cluster.go - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method clusterClient._pickMulti has 73 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (c *clusterClient) _pickMulti(multi []Completed) (retries *connretry, last uint16, toReplica bool) {
    last = cmds.InitSlot
    init := false

    for _, cmd := range multi {
        Severity: Minor
        Found in cluster.go - About 1 hr to fix

          Method clusterClient._pickMultiCache has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
          Open

          func (c *clusterClient) _pickMultiCache(multi []CacheableTTL) *connretrycache {
    c.mu.RLock()
    defer c.mu.RUnlock()

    count := conncountp.Get(len(c.conns), len(c.conns))
          Severity: Minor
          Found in cluster.go - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method clusterClient.doMulti has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
          Open

          func (c *clusterClient) doMulti(ctx context.Context, slot uint16, multi []Completed, toReplica bool) []RedisResult {
retry:
    cc, err := c.pick(ctx, slot, toReplica)
    if err != nil {
        return fillErrs(len(multi), err)
          Severity: Minor
          Found in cluster.go - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method clusterClient._pickMultiCache has 54 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          func (c *clusterClient) _pickMultiCache(multi []CacheableTTL) *connretrycache {
    c.mu.RLock()
    defer c.mu.RUnlock()

    count := conncountp.Get(len(c.conns), len(c.conns))
          Severity: Minor
          Found in cluster.go - About 1 hr to fix

            Method clusterClient.doresultfn has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            func (c *clusterClient) doresultfn(ctx context.Context, results *redisresults, retries *connretry, mu *sync.Mutex, cc conn, cIndexes []int, commands []Completed, resps []RedisResult) {
            Severity: Major
            Found in cluster.go - About 1 hr to fix

              Method clusterClient.resultcachefn has 8 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              func (c *clusterClient) resultcachefn(ctx context.Context, results *redisresults, retries *connretrycache, mu *sync.Mutex, cc conn, cIndexes []int, commands []CacheableTTL, resps []RedisResult) {
              Severity: Major
              Found in cluster.go - About 1 hr to fix

                Method clusterClient.doretrycache has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                func (c *clusterClient) doretrycache(ctx context.Context, cc conn, results *redisresults, retries *connretrycache, re *retrycache, mu *sync.Mutex, wg *sync.WaitGroup) {
                Severity: Major
                Found in cluster.go - About 50 mins to fix

                  Method clusterClient.doretry has 7 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  func (c *clusterClient) doretry(ctx context.Context, cc conn, results *redisresults, retries *connretry, re *retry, mu *sync.Mutex, wg *sync.WaitGroup) {
                  Severity: Major
                  Found in cluster.go - About 50 mins to fix

                    Method dedicatedClusterClient.DoMulti has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
                    Open

                    func (c *dedicatedClusterClient) DoMulti(ctx context.Context, multi ...Completed) (resp []RedisResult) {
    if len(multi) == 0 {
        return nil
    }
    slot := chooseSlot(multi)
                    Severity: Minor
                    Found in cluster.go - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Avoid deeply nested control flow statements.
                    Open

                                } else if err.IsClusterDown() || err.IsTryAgain() {
                mode = RedirectRetry
            }
                    Severity: Major
                    Found in cluster.go - About 45 mins to fix

                      Function newClusterClient has 5 return statements (exceeds 4 allowed).
                      Open

                      func newClusterClient(opt *ClientOption, connFn connFn) (client *clusterClient, err error) {
    client = &clusterClient{
        cmd:    cmds.NewBuilder(cmds.InitSlot),
        connFn: connFn,
        opt:    opt,
                      Severity: Major
                      Found in cluster.go - About 35 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        func (c *clusterClient) doretrycache(ctx context.Context, cc conn, results *redisresults, retries *connretrycache, re *retrycache, mu *sync.Mutex, wg *sync.WaitGroup) {
    if len(re.commands) != 0 {
        resps := cc.DoMultiCache(ctx, re.commands...)
        c.resultcachefn(ctx, results, retries, mu, cc, re.cIndexes, re.commands, resps.s)
        resultsp.Put(resps)
                        Severity: Major
                        Found in cluster.go and 1 other location - About 3 hrs to fix
                        cluster.go on lines 652..667

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 265.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                        func (c *clusterClient) doretry(ctx context.Context, cc conn, results *redisresults, retries *connretry, re *retry, mu *sync.Mutex, wg *sync.WaitGroup) {
    if len(re.commands) != 0 {
        resps := cc.DoMulti(ctx, re.commands...)
        c.doresultfn(ctx, results, retries, mu, cc, re.cIndexes, re.commands, resps.s)
        resultsp.Put(resps)
                        Severity: Major
                        Found in cluster.go and 1 other location - About 3 hrs to fix
                        cluster.go on lines 932..947

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 265.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status