rueian/rueidis

View on GitHub

Showing 130 of 649 total issues

Method RedisMessage.AsZScores has 5 return statements (exceeds 4 allowed).
Open

func (m *RedisMessage) AsZScores() ([]ZScore, error) {
    arr, err := m.ToArray()
    if err != nil {
        return nil, err
    }
Severity: Major
Found in message.go - About 35 mins to fix

    Function readB has 5 return statements (exceeds 4 allowed).
    Open

    func readB(i *bufio.Reader) (string, error) {
        length, err := readI(i)
        if err != nil {
            return "", err
        }
    Severity: Major
    Found in resp.go - About 35 mins to fix

      Method countingBloomFilter.ExistsMulti has 5 return statements (exceeds 4 allowed).
      Open

      func (f *countingBloomFilter) ExistsMulti(ctx context.Context, keys []string) ([]bool, error) {
          if len(keys) == 0 {
              return nil, nil
          }
      
      
      Severity: Major
      Found in rueidisprob/countingbloomfilter.go - About 35 mins to fix

        Method sentinelClient.listWatch has 5 return statements (exceeds 4 allowed).
        Open

        func (c *sentinelClient) listWatch(cc conn) (target string, sentinels []string, err error) {
            ctx := context.Background()
            sentinelsCMD := c.cmd.SentinelSentinels().Master(c.mOpt.Sentinel.MasterSet).Build()
            getMasterCMD := c.cmd.SentinelGetMasterAddrByName().Master(c.mOpt.Sentinel.MasterSet).Build()
            replicasCMD := c.cmd.SentinelReplicas().Master(c.mOpt.Sentinel.MasterSet).Build()
        Severity: Major
        Found in sentinel.go - About 35 mins to fix

          Function readNextMessage has 5 return statements (exceeds 4 allowed).
          Open

          func readNextMessage(i *bufio.Reader) (m RedisMessage, err error) {
              var attrs *RedisMessage
              var typ byte
              for {
                  if typ, err = i.ReadByte(); err != nil {
          Severity: Major
          Found in resp.go - About 35 mins to fix

            Function NewCountingBloomFilter has 5 return statements (exceeds 4 allowed).
            Open

            func NewCountingBloomFilter(
                client rueidis.Client,
                name string,
                expectedNumberOfItems uint,
                falsePositiveRate float64,
            Severity: Major
            Found in rueidisprob/countingbloomfilter.go - About 35 mins to fix

              Method countingBloomFilter.ItemMinCountMulti has 5 return statements (exceeds 4 allowed).
              Open

              func (f *countingBloomFilter) ItemMinCountMulti(ctx context.Context, keys []string) ([]uint, error) {
                  if len(keys) == 0 {
                      return nil, nil
                  }
              
              
              Severity: Major
              Found in rueidisprob/countingbloomfilter.go - About 35 mins to fix

                Function readI has 5 return statements (exceeds 4 allowed).
                Open

                func readI(i *bufio.Reader) (v int64, err error) {
                    bs, err := i.ReadSlice('\n')
                    if err != nil {
                        return 0, err
                    }
                Severity: Major
                Found in resp.go - About 35 mins to fix

                  Method pipe.Receive has 5 return statements (exceeds 4 allowed).
                  Open

                  func (p *pipe) Receive(ctx context.Context, subscribe Completed, fn func(message PubSubMessage)) error {
                      if p.nsubs == nil || p.psubs == nil || p.ssubs == nil {
                          return p.Error()
                      }
                  
                  
                  Severity: Major
                  Found in pipe.go - About 35 mins to fix

                    Method RedisMessage.AsIntMap has a Cognitive Complexity of 21 (exceeds 20 allowed). Consider refactoring.
                    Open

                    func (m *RedisMessage) AsIntMap() (map[string]int64, error) {
                        if err := m.Error(); err != nil {
                            return nil, err
                        }
                        if (m.IsMap() || m.IsArray()) && len(m.values)%2 == 0 {
                    Severity: Minor
                    Found in message.go - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Severity
                    Category
                    Status
                    Source
                    Language