rueian/rueidis

View on GitHub
rueidisprob/countingbloomfilter.go

Summary

Maintainability
B
5 hrs
Test Coverage

Method countingBloomFilter.ItemMinCountMulti has 5 return statements (exceeds 4 allowed).
Open

func (f *countingBloomFilter) ItemMinCountMulti(ctx context.Context, keys []string) ([]uint64, error) {
    if len(keys) == 0 {
        return nil, nil
    }

Severity: Major
Found in rueidisprob/countingbloomfilter.go - About 35 mins to fix

    Function NewCountingBloomFilter has 5 return statements (exceeds 4 allowed).
    Open

    func NewCountingBloomFilter(
        client rueidis.Client,
        name string,
        expectedNumberOfItems uint,
        falsePositiveRate float64,
    Severity: Major
    Found in rueidisprob/countingbloomfilter.go - About 35 mins to fix

      Method countingBloomFilter.ExistsMulti has 5 return statements (exceeds 4 allowed).
      Open

      func (f *countingBloomFilter) ExistsMulti(ctx context.Context, keys []string) ([]bool, error) {
          if len(keys) == 0 {
              return nil, nil
          }
      
      
      Severity: Major
      Found in rueidisprob/countingbloomfilter.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (f *countingBloomFilter) indexes(keys []string) []string {
            allIndexes := make([]string, 0, len(keys)*int(f.hashIterations))
            size := uint64(f.size)
            for _, key := range keys {
                h1, h2 := hash([]byte(key))
        Severity: Major
        Found in rueidisprob/countingbloomfilter.go and 1 other location - About 1 hr to fix
        rueidisprob/bloomfilter.go on lines 235..245

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 161.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (f *countingBloomFilter) Count(ctx context.Context) (uint64, error) {
            resp := f.client.Do(
                ctx,
                f.client.B().
                    Get().
        Severity: Major
        Found in rueidisprob/countingbloomfilter.go and 1 other location - About 1 hr to fix
        rueidisprob/bloomfilter.go on lines 320..338

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 139.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (f *countingBloomFilter) Delete(ctx context.Context) error {
            resp := f.client.Do(
                ctx,
                f.client.B().
                    Eval().
        Severity: Major
        Found in rueidisprob/countingbloomfilter.go and 2 other locations - About 50 mins to fix
        rueidisprob/bloomfilter.go on lines 294..305
        rueidisprob/bloomfilter.go on lines 307..318

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 118.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status