Sign upLogin

rugby-board/rugby-board

View on GitHub
Star

Showing 11 of 11 total issues

Method info has 137 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def info
    @info_list = [
      {
        id: 'story',
        title: '橄榄球故事',
Severity: Major
Found in app/controllers/wiki_controller.rb - About 5 hrs to fix

    Method balance_score has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

      def balance_score(content)
    table_head, table_body = parse_table(content)
    return content if table_head.nil? || table_body.nil?

    new_body = ""
    Severity: Minor
    Found in app/helpers/news_helper.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method balance_score has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def balance_score(content)
    table_head, table_body = parse_table(content)
    return content if table_head.nil? || table_body.nil?

    new_body = ""
    Severity: Minor
    Found in app/helpers/news_helper.rb - About 1 hr to fix

      Method list has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def list
    # get channels
    channel_id = get_channel_id(params[:channel])
    if channel_id.nil?
      redirect_to "/404"
      Severity: Minor
      Found in app/controllers/news_controller.rb - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                      newScore0 = '&nbsp;' * (largerScoreWidth - newScore0.length) + score0 if newScore0.length < largerScoreWidth
        Severity: Major
        Found in app/helpers/news_helper.rb - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                        newScore1 = score1 + '&nbsp;' * (largerScoreWidth - newScore1.length) if newScore1.length < largerScoreWidth
          Severity: Major
          Found in app/helpers/news_helper.rb - About 45 mins to fix

            Method filter_translation has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def filter_translation(data)
    table_head, table_body = parse_table(data[:content])
    return data if table_head.nil? || table_body.nil?

    new_body = ""
            Severity: Minor
            Found in app/helpers/news_helper.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  {
        id: 'story',
        title: '橄榄球故事',
        icon: 'coffee',
        entries: [
            Severity: Minor
            Found in app/controllers/wiki_controller.rb and 1 other location - About 35 mins to fix
            app/controllers/wiki_controller.rb on lines 79..104

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 34.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  {
        id: 'rule',
        title: '规则介绍',
        icon: 'exclamation',
        entries: [
            Severity: Minor
            Found in app/controllers/wiki_controller.rb and 1 other location - About 35 mins to fix
            app/controllers/wiki_controller.rb on lines 29..54

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 34.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  {
        id: 'culture',
        title: '橄榄球文化',
        icon: 'book',
        entries: [
            Severity: Minor
            Found in app/controllers/wiki_controller.rb and 1 other location - About 25 mins to fix
            app/controllers/wiki_controller.rb on lines 106..127

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 29.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                  {
        id: 'match',
        title: '赛事相关',
        icon: 'flag-checkered',
        entries: [
            Severity: Minor
            Found in app/controllers/wiki_controller.rb and 1 other location - About 25 mins to fix
            app/controllers/wiki_controller.rb on lines 56..77

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 29.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Severity
            Category
            Status
            Source
            Language