Sign upLogin

rugby-board/rugby-board

View on GitHub
Star

Showing 7 of 11 total issues

Method info has 137 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def info
    @info_list = [
      {
        id: 'story',
        title: '橄榄球故事',
Severity: Major
Found in app/controllers/wiki_controller.rb - About 5 hrs to fix

    Method balance_score has a Cognitive Complexity of 32 (exceeds 5 allowed). Consider refactoring.
    Open

      def balance_score(content)
    table_head, table_body = parse_table(content)
    return content if table_head.nil? || table_body.nil?

    new_body = ""
    Severity: Minor
    Found in app/helpers/news_helper.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method balance_score has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def balance_score(content)
    table_head, table_body = parse_table(content)
    return content if table_head.nil? || table_body.nil?

    new_body = ""
    Severity: Minor
    Found in app/helpers/news_helper.rb - About 1 hr to fix

      Method list has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def list
    # get channels
    channel_id = get_channel_id(params[:channel])
    if channel_id.nil?
      redirect_to "/404"
      Severity: Minor
      Found in app/controllers/news_controller.rb - About 1 hr to fix

        Avoid deeply nested control flow statements.
        Open

                      newScore0 = '&nbsp;' * (largerScoreWidth - newScore0.length) + score0 if newScore0.length < largerScoreWidth
        Severity: Major
        Found in app/helpers/news_helper.rb - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                        newScore1 = score1 + '&nbsp;' * (largerScoreWidth - newScore1.length) if newScore1.length < largerScoreWidth
          Severity: Major
          Found in app/helpers/news_helper.rb - About 45 mins to fix

            Method filter_translation has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

              def filter_translation(data)
    table_head, table_body = parse_table(data[:content])
    return data if table_head.nil? || table_body.nil?

    new_body = ""
            Severity: Minor
            Found in app/helpers/news_helper.rb - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language