rugk/threema-msgapi-sdk-php

View on GitHub
source/Threema/Console/Common.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid using short method names like Common::e(). The configured minimum method name length is 3.
Open

    public static function e($msg) {
        $STDERR = fopen('php://stderr', 'w+');
        fwrite($STDERR, $msg."\n");

    }
Severity: Minor
Found in source/Threema/Console/Common.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like Common::l(). The configured minimum method name length is 3.
Open

    public static function l($string = '', $indent = 0) {
        $pad = str_repeat('  ', $indent);
        echo $pad . wordwrap($string, 100, "\n" . $pad) . "\n";
    }
Severity: Minor
Found in source/Threema/Console/Common.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid using short method names like Common::ln(). The configured minimum method name length is 3.
Open

    public static function ln($string = '') {
        echo $string . "\n";
    }
Severity: Minor
Found in source/Threema/Console/Common.php by phpmd

ShortMethodName

Since: 0.2

Detects when very short method names are used.

Example

class ShortMethod {
    public function a( $index ) { // Violation
    }
}

Source https://phpmd.org/rules/naming.html#shortmethodname

Avoid variables with short names like $o. Configured minimum length is 3.
Open

            $o = func_get_arg($n);
Severity: Minor
Found in source/Threema/Console/Common.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The variable $STDERR is not named in camelCase.
Open

    public static function e($msg) {
        $STDERR = fopen('php://stderr', 'w+');
        fwrite($STDERR, $msg."\n");

    }
Severity: Minor
Found in source/Threema/Console/Common.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $STDERR is not named in camelCase.
Open

    public static function e($msg) {
        $STDERR = fopen('php://stderr', 'w+');
        fwrite($STDERR, $msg."\n");

    }
Severity: Minor
Found in source/Threema/Console/Common.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status